From owner-svn-src-all@freebsd.org Mon Sep 19 21:22:44 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1031BE1D59; Mon, 19 Sep 2016 21:22:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8CEA2D2A; Mon, 19 Sep 2016 21:22:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 9262810AF8D; Mon, 19 Sep 2016 17:22:42 -0400 (EDT) From: John Baldwin To: "Ngie Cooper (yaneurabeya)" Cc: "Conrad E. Meyer" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305998 - in head/usr.bin: cmp indent tr Date: Mon, 19 Sep 2016 14:22:37 -0700 Message-ID: <8333248.dV1m5xp1ki@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; ) In-Reply-To: References: <201609192043.u8JKh3jv040006@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 19 Sep 2016 17:22:42 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 21:22:44 -0000 On Monday, September 19, 2016 01:45:01 PM Ngie Cooper wrote: >=20 > > On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer wrot= e: > >=20 > > Author: cem > > Date: Mon Sep 19 20:43:03 2016 > > New Revision: 305998 > > URL: https://svnweb.freebsd.org/changeset/base/305998 > >=20 > > Log: > > Move sys/capsicum.h includes after types.h or param.h > >=20 > > This is not actually documented or even implied in style(9). Make= the change > > to match convention. Someone should document this convention in s= tyle(9). > >=20 > > Reported by:=09jhb > > Sponsored by:=09EMC Dell Isilon >=20 > Uh=E2=80=A6 yes it clearly states it in style(9). From https://www.fr= eebsd.org/cgi/man.cgi?query=3Dstyle&sektion=3D9 : > Kernel include files (i.e. sys/*.h) come first; normally, includ= e > OR , but not both. inc= ludes > , and it is okay to depend on that. It doesn't actually say that types.h/param.h has to come before other s= ys/*.h headers though. Normally sys/foo.h requires sys/types.h to compile hen= ce the rule, but sys/capsicum.h gets around this by a nested include of sys/pa= ram.h (which is itself probably dubious). I do think we should explicitly add a note to style.9 though to say tha= t types.h|param.h comes first. --=20 John Baldwin