From owner-svn-src-all@FreeBSD.ORG Tue Oct 15 16:32:11 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DDE0A334; Tue, 15 Oct 2013 16:32:10 +0000 (UTC) (envelope-from freebsd@allanjude.com) Received: from mx1.scaleengine.net (beauharnois2.bhs1.scaleengine.net [142.4.218.15]) by mx1.freebsd.org (Postfix) with ESMTP id 9AA7E24ED; Tue, 15 Oct 2013 16:32:10 +0000 (UTC) Received: from [10.1.1.1] (S01060001abad1dea.hm.shawcable.net [50.70.108.129]) (Authenticated sender: allan.jude@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 290FE3CBAC; Tue, 15 Oct 2013 16:32:07 +0000 (UTC) Message-ID: <525D6E24.70901@allanjude.com> Date: Tue, 15 Oct 2013 12:32:36 -0400 From: Allan Jude User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Devin Teske , Bryan Drewery Subject: Re: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts References: <201310112041.r9BKfZeT002056@svn.freebsd.org> <20131015145032.GD98118@admin.xzibition.com> <13CA24D6AB415D428143D44749F57D720FC6A04C@LTCFISWMSGMB21.FNFIS.com> <525D5E07.1070900@allanjude.com> <13CA24D6AB415D428143D44749F57D720FC6A61F@LTCFISWMSGMB21.FNFIS.com> In-Reply-To: <13CA24D6AB415D428143D44749F57D720FC6A61F@LTCFISWMSGMB21.FNFIS.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , "Teske, Devin" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 16:32:11 -0000 On 2013-10-15 12:28, Teske, Devin wrote: > On Oct 15, 2013, at 8:23 AM, Allan Jude wrote: > >> On 2013-10-15 11:00, Teske, Devin wrote: >>> CC'ing Allan Jude for feedback (I didn't have a hand in the >>> selection of those values) >>> >>> -- >>> Devin >>> >>> >>> On Oct 15, 2013, at 7:50 AM, Bryan Drewery wrote: >>> >>> >>>> On Fri, Oct 11, 2013 at 08:41:35PM +0000, Devin Teske wrote: >>>> >>>>> Author: dteske >>>>> >>>>> Date: Fri Oct 11 20:41:35 2013 >>>>> >>>>> New Revision: 256343 >>>>> >>>>>>> URL: http://svnweb.freebsd.org/changeset/base/256343 >>>>>>> >>>>>>> >>>>> Log: >>>>> >>>>> Add zfsboot module as an option for automatic configuration. Default is >>>>> >>>>> to run interactively but it can be scripted too (optinally completely >>>>> >>>>> non-interactive). Currently supports GELI and all ZFS vdev types. Also >>>>> >>>>> performs validation on selections/settings providing error messages if >>>>> >>>>> necessary, explaining (in plain language) what the issue is. Currently >>>>> >>>>> the auto partitioning of naked disks only supports GPT and MBR (VTOC8 >>>>> >>>>> pending for sparc64), so is only available for i386/amd64 install. >>>>> >>>>>>> Submitted by: Allan Jude >>>>> , myself >>>>> >>>>>>> Reviewed by: Allan Jude >>>>>>> >>>>> Approved by: re (glebius) >>>>> >>>>>>> >>>>> Added: >>>>> >>>>> head/usr.sbin/bsdinstall/scripts/zfsboot (contents, props changed) >>>>> >>>>> Modified: >>>>> >>>>> head/usr.sbin/bsdinstall/bsdinstall >>>>> >>>>> head/usr.sbin/bsdinstall/scripts/Makefile >>>>> >>>>> head/usr.sbin/bsdinstall/scripts/auto >>>>> >>>>> head/usr.sbin/bsdinstall/scripts/config >>>>> >>>>>>> >>>>> +# Should we use gnop(8) to configure a transparent mapping to 4K sectors? >>>>> >>>>> +# >>>>> >>>>> +: ${ZFSBOOT_GNOP_4K_FORCE_ALIGN:=1} >>>>> >>>>> >>>>> >>>> I believe this trick is no longer needed after r254591. >>>> >> This may be the case, I am not sure if r254591 'always' fixes the problem, maybe someone else can weight in with a more definite yes/no >> > I'll hold off on doing anything with 4K sectors gnop hack until > we get confirmation. > > > > > >>>>> *** DIFF OUTPUT TRUNCATED AT 1000 LINES *** >>>>> >>>>> >>>> ... >>>> >>>>> +# Default name for the boot environment parent dataset >>>>> >>>>> +# >>>>> >>>>> +: ${ZFSBOOT_BEROOT_NAME:=bootenv} >>>>> >>>>> >>>> ... >>>> >>>>> + # Set bootfs property >>>>> >>>>> + zpool set bootfs="$poolname/$ZFSBOOT_BEROOT_NAME/$ZFSBOOT_BOOTFS_NAME" \ >>>>> >>>>> + "$poolname" || return $FAILURE >>>>> >>>>> >>>>> >>>> Can you please make ZFSBOOT_BEROOT_NAME be ROOT by default? This is what >>>> >>>> sysutils/beadm, OpenSolaris/Illumos beadm, and I believe PC-BSD all expect >>>> >>>>> and use as well. >> I suppose. I dislike having a dataset in all caps, and with a not exactly descriptive name. beadm-devel (used in PCBSD) supports figuring out where whatever ZFSBOOT_BEROOT_NAME you used, but since sysutils/beadm does not, POLA suggests we change the value back to ROOT >> > So we have consensus? > > I need to know today if we're going to get it into 10.0-BETA2 (3-day MFC cycle). Lets change ZFSBOOT_BEROOT_NAME to 'ROOT' and remove the /usr/local and /var/db/pkg datasets entirely (so they become part of the BE). Based on IRC discussion with bdrewery and Shawn Webb -- Allan Jude