From owner-p4-projects  Tue May  7  7:55:46 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 80BDE37B40C; Tue,  7 May 2002 07:55:38 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id B08EA37B403
	for <perforce@freebsd.org>; Tue,  7 May 2002 07:55:37 -0700 (PDT)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g47EtbN90702
	for perforce@freebsd.org; Tue, 7 May 2002 07:55:37 -0700 (PDT)
	(envelope-from mini@freebsd.org)
Date: Tue, 7 May 2002 07:55:37 -0700 (PDT)
Message-Id: <200205071455.g47EtbN90702@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to mini@freebsd.org using -f
From: Jonathan Mini <mini@FreeBSD.org>
Subject: PERFORCE change 10954 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=10954

Change 10954 by mini@mini_stylus on 2002/05/07 07:55:28

	Instead of marking ucred NULL when we drop our reference,
	don't try to drop ucred again in thread_reap(), because
	it is always dropped before thread_reap() is called.

Affected files ...

... //depot/projects/kse/sys/kern/kern_exit.c#45 edit
... //depot/projects/kse/sys/kern/kern_thread.c#44 edit

Differences ...

==== //depot/projects/kse/sys/kern/kern_exit.c#45 (text+ko) ====

@@ -375,7 +375,6 @@
 	 * in theory nothing should be using it at this point.
 	 */
 	crfree(td->td_ucred);
-	td->td_ucred = NULL;
 
 	/*
 	 * Remove proc from allproc queue and pidhash chain.

==== //depot/projects/kse/sys/kern/kern_thread.c#44 (text+ko) ====

@@ -107,13 +107,6 @@
 	if (td == NULL)
 		return;
 #endif
-	/* Undo all the linkages made by proc_linkup */
-	/* thread_unlink(td); */ /* already done in thread_exit() */
-
-	if (td->td_ucred) {
-		crfree(td->td_ucred);
-		td->td_ucred = NULL;
-	}
 
 	active_threads--;
 	if (cached_threads < thread_cache_size) {

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message