From owner-cvs-all@FreeBSD.ORG Tue Sep 30 16:19:58 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4356A106569C; Tue, 30 Sep 2008 16:19:58 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1AD518FC2C; Tue, 30 Sep 2008 16:19:58 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTP id C0DD946B29; Tue, 30 Sep 2008 12:19:57 -0400 (EDT) Date: Tue, 30 Sep 2008 17:19:57 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Ganbold In-Reply-To: <48DF2010.6030309@micom.mng.net> Message-ID: References: <200809271014.m8RAENka041457@repoman.freebsd.org> <48DE5C4F.8040807@micom.mng.net> <48DF2010.6030309@micom.mng.net> User-Agent: Alpine 1.10 (BSF 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Sep 2008 16:19:58 -0000 On Sun, 28 Sep 2008, Ganbold wrote: >> Indeed -- when an inpcb doesn't have a socket, ipfw will go ahead and do a >> lookup for an inpcb even though one is passed down. I've committed a >> change that short-circuits that and marks the credential lookup as failed. >> Give it a try now? > > Thanks a lot, Robert, it was indeed simple effective fix. So far no crash :) > With loads like pkg_adding emacs (which adds bunch of other packages) on > plain CURRENT, downloading FreeBSD ISO with axel (20 simultaneous > connection) through http works fine here. Good news. We'll want to keep an eye on this one as the 7.0 release cycle progresses, and there may be other unexpected edge case problems from the rwlock change. On the whole it seems to have been very successful, but the view that -CURRENT doesn't receive a whole lot of stress testing is reinforced... Robert N M Watson Computer Laboratory University of Cambridge > > test# ipfw show > 00040 1184006 673239338 allow ip from any to any uid root > 00100 0 0 allow ip from any to any via lo0 > 00200 0 0 deny ip from any to 127.0.0.0/8 > 00300 0 0 deny ip from 127.0.0.0/8 to any > 65000 60 7426 allow ip from any to any > 65535 0 0 deny ip from any to any > test# > > > Ganbold > >> >> Robert N M Watson >> Computer Laboratory >> University of Cambridge >> _______________________________________________ >> cvs-all@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/cvs-all >> To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" >> >> >> > > > -- > If it ain't broke, don't fix it. >