Date: Mon, 22 Jan 2018 20:56:21 +0000 (UTC) From: Eric Joyner <erj@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r328265 - head/sys/dev/ixgbe Message-ID: <201801222056.w0MKuLE1042391@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: erj Date: Mon Jan 22 20:56:21 2018 New Revision: 328265 URL: https://svnweb.freebsd.org/changeset/base/328265 Log: ixv(4): Stop setting editing ifnet flags in ixv_if_init() In iflib, the device-specific init() function isn't supposed to edit the struct ifnet driver flags. If it does, it'll cause an MPASS() assert in iflib to fail. PR: 225312 Reported by: bhughes@ Modified: head/sys/dev/ixgbe/if_ixv.c Modified: head/sys/dev/ixgbe/if_ixv.c ============================================================================== --- head/sys/dev/ixgbe/if_ixv.c Mon Jan 22 20:49:17 2018 (r328264) +++ head/sys/dev/ixgbe/if_ixv.c Mon Jan 22 20:56:21 2018 (r328265) @@ -662,10 +662,6 @@ ixv_if_init(if_ctx_t ctx) /* And now turn on interrupts */ ixv_if_enable_intr(ctx); - /* Now inform the stack we're ready */ - ifp->if_drv_flags |= IFF_DRV_RUNNING; - ifp->if_drv_flags &= ~IFF_DRV_OACTIVE; - return; } /* ixv_if_init */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801222056.w0MKuLE1042391>