From owner-freebsd-ports@FreeBSD.ORG Fri Jan 9 16:11:24 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4672C16A4CE for ; Fri, 9 Jan 2004 16:11:24 -0800 (PST) Received: from sccrmhc13.comcast.net (sccrmhc13.comcast.net [204.127.202.64]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CB5743D3F for ; Fri, 9 Jan 2004 16:11:21 -0800 (PST) (envelope-from adam@migus.org) Received: from ludo.migus.org ([68.55.80.136]) by comcast.net (sccrmhc13) with ESMTP id <2004011000112001600nl9nhe>; Sat, 10 Jan 2004 00:11:20 +0000 Received: from localhost (localhost [127.0.0.1]) by localhost (Postfix) with ESMTP id 554EFA1017 for ; Fri, 9 Jan 2004 19:11:20 -0500 (EST) Received: from ludo.migus.org ([127.0.0.1]) by localhost (ludo.migus.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 36800-03 for ; Fri, 9 Jan 2004 19:11:19 -0500 (EST) Received: from ganyopa.migus.org (ganyopa.migus.org [192.168.4.2]) by ludo.migus.org (Postfix) with ESMTP id 7524AA1001 for ; Fri, 9 Jan 2004 19:11:19 -0500 (EST) From: "Adam C. Migus" Organization: Migus Dot Org To: ports@freebsd.org Date: Fri, 9 Jan 2004 19:11:19 -0500 User-Agent: KMail/1.5 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200401091911.19186.adam@migus.org> X-Virus-Scanned: by amavisd-new at migus.org Subject: textproc/p5-XML-LibXML broken, why? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jan 2004 00:11:24 -0000 su-2.05b# uname -a FreeBSD ludo.migus.org 5.1-RELEASE-p10 FreeBSD 5.1-RELEASE-p10 #5: Sat Oct 25 23:51:05 EDT 2003 amigus@ludo.migus.org:/obj/freebsd/sys/src/freebsd/RELENG_5_1/src/sys/SMP_FAST i386 su-2.05b# pwd /src/freebsd/ports/textproc/p5-XML-LibXML su-2.05b# make ===> p5-XML-LibXML-1.56 is marked as broken: Does not compile on FreeBSD 501000. su-2.05b# I attempted to locate the error in the bento logs but the log file's gone so I'm not entirely sure why it's broken but when I remove the broken marking from Makefile it compiles however I get the following warnings under both FreeBSD and NetBSD: LibXML.xs:73: warning: duplicate `extern' LibXML.xs:74: warning: duplicate `extern' LibXML.xs:76: warning: duplicate `extern' LibXML.xs:77: warning: duplicate `extern' LibXML.xs:78: warning: duplicate `extern' LibXML.xs:79: warning: duplicate `extern' Is this the reason it was marked as broken? The following patch removes them: diff -Nru --exclude=CVS p5-XML-LibXML.orig/Makefile p5-XML-LibXML/Makefile --- p5-XML-LibXML.orig/Makefile Tue Dec 23 01:50:53 2003 +++ p5-XML-LibXML/Makefile Fri Jan 9 18:49:32 2004 @@ -36,8 +36,4 @@ .include -.if ${OSVERSION} >= 500113 -BROKEN= "Does not compile on FreeBSD ${OSVERSION}" -.endif - .include diff -Nru --exclude=CVS p5-XML-LibXML.orig/files/patch-LibXML.xs p5-XML-LibXML/files/patch-LibXML.xs --- p5-XML-LibXML.orig/files/patch-LibXML.xs Wed Dec 31 19:00:00 1969 +++ p5-XML-LibXML/files/patch-LibXML.xs Sat Jan 3 03:27:21 2004 @@ -0,0 +1,23 @@ +--- LibXML.xs.orig 2003-12-22 10:38:06.000000000 -0500 ++++ LibXML.xs 2003-12-22 10:38:12.000000000 -0500 +@@ -64,20 +64,6 @@ + } + #endif + +-#ifdef VMS +-extern int xmlDoValidityCheckingDefaultVal; +-#define xmlDoValidityCheckingDefaultValue xmlDoValidityCheckingDefaultVal +-extern int xmlSubstituteEntitiesDefaultVal; +-#define xmlSubstituteEntitiesDefaultValue xmlSubstituteEntitiesDefaultVal +-#else +-LIBXML_DLL_IMPORT extern int xmlDoValidityCheckingDefaultValue; +-LIBXML_DLL_IMPORT extern int xmlSubstituteEntitiesDefaultValue; +-#endif +-LIBXML_DLL_IMPORT extern int xmlGetWarningsDefaultValue; +-LIBXML_DLL_IMPORT extern int xmlKeepBlanksDefaultValue; +-LIBXML_DLL_IMPORT extern int xmlLoadExtDtdDefaultValue; +-LIBXML_DLL_IMPORT extern int xmlPedanticParserDefaultValue; +- + #define TEST_PERL_FLAG(flag) \ + SvTRUE(perl_get_sv(flag, FALSE)) ? 1 : 0 + FWIW I contacted the perl package maintainer some time ago and got no response. The cvs log for the port indicates that the port maintainer was contacted. Can this patch be put in place to unbreak the port until such a time as someone comes up with a better fix? -- Adam C. Migus - http://people.migus.org/~amigus/