From owner-freebsd-ports-bugs@FreeBSD.ORG Tue May 1 11:20:08 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2F6DD1065675 for ; Tue, 1 May 2012 11:20:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 011458FC15 for ; Tue, 1 May 2012 11:20:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q41BK7iM049514 for ; Tue, 1 May 2012 11:20:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q41BK78T049513; Tue, 1 May 2012 11:20:07 GMT (envelope-from gnats) Resent-Date: Tue, 1 May 2012 11:20:07 GMT Resent-Message-Id: <201205011120.q41BK78T049513@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Fabian Keil Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C0F4106564A for ; Tue, 1 May 2012 11:11:11 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id F13DC8FC08 for ; Tue, 1 May 2012 11:11:10 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q41BBAJj084161 for ; Tue, 1 May 2012 11:11:10 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q41BBAWo084160; Tue, 1 May 2012 11:11:10 GMT (envelope-from nobody) Message-Id: <201205011111.q41BBAWo084160@red.freebsd.org> Date: Tue, 1 May 2012 11:11:10 GMT From: Fabian Keil To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/167482: security/tor-devel: Additional Log directives in config file ignored due to rc script X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2012 11:20:08 -0000 >Number: 167482 >Category: ports >Synopsis: security/tor-devel: Additional Log directives in config file ignored due to rc script >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 01 11:20:07 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Fabian Keil >Release: HEAD >Organization: >Environment: FreeBSD r500.local 10.0-CURRENT FreeBSD 10.0-CURRENT #424 r+1ac027d: Mon Apr 30 22:59:10 CEST 2012 fk@r500.local:/usr/obj/usr/src/sys/ZOEY amd64 >Description: As of security/tor-devel 0.2.3.9.a, additional log files specified in torrc are overridden by the default rc script, due to a syntax change made upstream. Quoting the ChangeLog: | Changes in version 0.2.3.9-alpha - 2011-12-08 | [...] | o Minor features (new/different config options): | [...] | - Slightly change behavior of "list" options (that is, config | options that can appear more than once) when they appear both in | torrc and on the command line. Previously, the command-line options | would be appended to the ones from torrc. Now, the command-line | options override the torrc options entirely. This new behavior | allows the user to override list options (like exit policies and | ports to listen on) from the command line, rather than simply | appending to the list. | - You can get the old (appending) command-line behavior for "list" | options by prefixing the option name with a "+". >How-To-Repeat: Add a line like the following to /usr/local/etc/tor/torrc: Log [app]debug info file /usr/local/var/log/tor/debug.log restart tor, note that tor doesn't write to the file. >Fix: The attached patch adds the "+" to the list option, thus getting the previous behavior again. The alternative would be to remove the --Log option completely, forcing the user to specify all log files in the torrc. As a user with multiple log files I would prefer that, but users with a single log file probably wouldn't. Patch attached with submission follows: --- .zfs/snapshot/2012-05-01_12:58/security/tor-devel/files/tor.in 2012-05-01 12:56:57.404278382 +0200 +++ security/tor-devel/files/tor.in 2012-05-01 12:59:07.042280697 +0200 @@ -37,7 +37,7 @@ required_dirs=${tor_datadir} pidfile=${tor_pidfile} command="%%PREFIX%%/bin/${name}" -command_args="-f ${tor_conf} --PidFile ${tor_pidfile} --RunAsDaemon 1 --DataDirectory ${tor_datadir} --Log notice\ file\ ${tor_logfile}" +command_args="-f ${tor_conf} --PidFile ${tor_pidfile} --RunAsDaemon 1 --DataDirectory ${tor_datadir} --+Log notice\ file\ ${tor_logfile}" extra_commands="log" log_cmd="${name}_log" >Release-Note: >Audit-Trail: >Unformatted: