From owner-freebsd-emulation@FreeBSD.ORG  Mon Oct  6 10:00:37 2003
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 925E116A4B3
	for <freebsd-emulation@hub.freebsd.org>;
	Mon,  6 Oct 2003 10:00:37 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A159F43FB1
	for <freebsd-emulation@hub.freebsd.org>;
	Mon,  6 Oct 2003 10:00:36 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h96H0aFY051957
	for <freebsd-emulation@freefall.freebsd.org>;
	Mon, 6 Oct 2003 10:00:36 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h96H0aup051956;
	Mon, 6 Oct 2003 10:00:36 -0700 (PDT)
	(envelope-from gnats)
Date: Mon, 6 Oct 2003 10:00:36 -0700 (PDT)
Message-Id: <200310061700.h96H0aup051956@freefall.freebsd.org>
To: freebsd-emulation@FreeBSD.org
From: Jan Srzednicki <w@expro.pl>
Subject: Re: ports/57465: kldunload rtc.ko causes a panic;
	yet it's in rc.d script
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Jan Srzednicki <w@expro.pl>
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>,
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>,
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Oct 2003 17:00:37 -0000

The following reply was made to PR ports/57465; it has been noted by GNATS.

From: Jan Srzednicki <w@expro.pl>
To: Philipp Mergenthaler <philipp.mergenthaler@stud.uni-karlsruhe.de>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: ports/57465: kldunload rtc.ko causes a panic; yet it's in rc.d script
Date: Mon, 6 Oct 2003 18:51:14 +0200

 On Thu, Oct 02, 2003 at 10:24:41AM +0200, Philipp Mergenthaler wrote:
 > The bug is that the module, on unloading, calls destroy_dev() twice
 > for its device. Doing this causes a panic.
 > 
 > Fix:
 > --- ports/emulators/rtc/files/rtc.c_orig	Thu Oct  2 10:20:17 2003
 > +++ ports/emulators/rtc/files/rtc.c	Thu Oct  2 09:58:13 2003
 > @@ -168,7 +168,6 @@
 >  	if (sc->var.flags.opened) {
 >  		return EBUSY;
 >  	}
 > -	destroy_dev(sc->dev);
 >  	FREE(sc, M_DEVBUF);
 >  	return error;
 >  }
 
 This one seems to work fine. Thanks. ;)
 
 -- 
 Jan 'Winfried' Srzednicki
 w@expro.pl