From owner-p4-projects  Tue May  7 18: 0:59 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1511337B408; Tue,  7 May 2002 18:00:42 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211])
	by hub.freebsd.org (Postfix) with ESMTP id 5355537B416
	for <perforce@freebsd.org>; Tue,  7 May 2002 18:00:34 -0700 (PDT)
Received: (qmail 17671 invoked from network); 8 May 2002 01:00:33 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender <jhb@FreeBSD.org>)
          by mail11.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <perforce@freebsd.org>; 8 May 2002 01:00:33 -0000
Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4])
	by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4810WF31299;
	Tue, 7 May 2002 21:00:32 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20020507210031.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200205072105.g47L58d47891@freefall.freebsd.org>
Date: Tue, 07 May 2002 21:00:31 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Adam Migus <amigus@FreeBSD.org>
Subject: RE: PERFORCE change 10969 for review
Cc: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG


On 07-May-2002 Adam Migus wrote:
> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=10969
> 
> Change 10969 by amigus@amigus_ganymede on 2002/05/07 14:04:56
> 
>       passwd and friends fail when the user has a '+' in their passwd
>       file for NIS.  It fails because _PWF_SOURCE is not set.  This
>       patch fixes it.  This is also a bug in 5.0-CURRENT so someone
>       should commit it to the main tree.

Ooo, nice catch!

> Affected files ...
> 
> ... //depot/projects/trustedbsd/mac/lib/libc/gen/getpwent.c#4 edit
> 
> Differences ...
> 
> ==== //depot/projects/trustedbsd/mac/lib/libc/gen/getpwent.c#4 (text+ko) ====
> 
> @@ -966,6 +966,9 @@
>                               break;
>                       }
>                       break;
> +             default:
> +                     _pw_passwd.pw_fields &= ~_PWF_SOURCE;
> +                     _pw_passwd.pw_fields |= _PWF_FILES;
>               }
>               if ((search == _PW_KEYBYNAME &&
>                           strcmp(_pw_passwd.pw_name, name) == 0)

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message