From owner-cvs-all Mon Jan 27 20: 0:30 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C24637B401; Mon, 27 Jan 2003 20:00:29 -0800 (PST) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7212043F75; Mon, 27 Jan 2003 20:00:28 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.6/8.12.6) with ESMTP id h0S40S0i024069; Mon, 27 Jan 2003 20:00:28 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.6/8.12.6/Submit) id h0S40S4Z024068; Mon, 27 Jan 2003 20:00:28 -0800 (PST) Date: Mon, 27 Jan 2003 20:00:28 -0800 (PST) From: Matthew Dillon Message-Id: <200301280400.h0S40S4Z024068@apollo.backplane.com> To: David Schultz Cc: "David O'Brien" , Greg Lehey , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/sysinstall label.c References: <200301251932.h0PJWZHo054126@repoman.freebsd.org> <20030125215919.GA6687@HAL9000.homeunix.com> <20030126013124.GD3641@sydney.worldwide.lemis.com> <20030126210426.GA23132@dragon.nuxi.com> <200301262108.h0QL8WRs068598@apollo.backplane.com> <20030127071241.GC1018@HAL9000.homeunix.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :Try to install without creating a swap partition. I haven't tried :this since circa DP2, so I don't recall exactly what it bitched :about, but I think it complained before it wrote the label. :Someone (Eric McCoy, I think) mentioned on one of the lists that :it is still an issue as of 5.0-RELEASE. I would try it myself if :I had a non-broken disk around that I could afford to trash. Ok, I tracked down the error message. Insofar as the swap goes I think we may simply be able to remove the test, as in the patch below. I haven't been able to test it yet for a myrid of reasons... my attempt to 'make release' fails so I cannot generate a new ISO, sysinstall in multi-user tries to write over / instead of installing on the specified hard disk, and so far my attempts to hack sysinstall to make it install to the specified hard disk have either failed with mounting errors or panic'd the system :-(. And the system I am testing on doesn't have a floppy. So if someone else can somehow test this it would be a help. -Matt Matthew Dillon Index: install.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/sysinstall/install.c,v retrieving revision 1.339 diff -u -r1.339 install.c --- install.c 17 Jan 2003 19:05:31 -0000 1.339 +++ install.c 28 Jan 2003 03:35:17 -0000 @@ -222,11 +222,13 @@ "in the label editor."); status = FALSE; } +#if 0 if (!swapdev && whinge) { msgConfirm("No swap devices found - you must create at least one\n" "swap partition."); status = FALSE; } +#endif return status; } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message