From owner-svn-src-head@FreeBSD.ORG Sat Jan 4 09:27:50 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1A2A161A; Sat, 4 Jan 2014 09:27:50 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 05FB511F2; Sat, 4 Jan 2014 09:27:50 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id s049RnmL034051; Sat, 4 Jan 2014 09:27:49 GMT (envelope-from pjd@svn.freebsd.org) Received: (from pjd@localhost) by svn.freebsd.org (8.14.7/8.14.7/Submit) id s049RnUw034050; Sat, 4 Jan 2014 09:27:49 GMT (envelope-from pjd@svn.freebsd.org) Message-Id: <201401040927.s049RnUw034050@svn.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 4 Jan 2014 09:27:49 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r260254 - head/sbin/geom/class/eli X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jan 2014 09:27:50 -0000 Author: pjd Date: Sat Jan 4 09:27:49 2014 New Revision: 260254 URL: http://svnweb.freebsd.org/changeset/base/260254 Log: Don't allow to create GELI providers with a sector size, which is no a power of 2. Noticed by: rwatson MFC after: 3 days Modified: head/sbin/geom/class/eli/geom_eli.c Modified: head/sbin/geom/class/eli/geom_eli.c ============================================================================== --- head/sbin/geom/class/eli/geom_eli.c Sat Jan 4 09:25:27 2014 (r260253) +++ head/sbin/geom/class/eli/geom_eli.c Sat Jan 4 09:27:49 2014 (r260254) @@ -789,7 +789,7 @@ eli_init(struct gctl_req *req) if (val == 0) md.md_sectorsize = secsize; else { - if (val < 0 || (val % secsize) != 0) { + if (val < 0 || (val % secsize) != 0 || !powerof2(val)) { gctl_error(req, "Invalid sector size."); return; }