Date: Mon, 19 Jan 2004 10:49:30 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Pav Lucistnik <pav@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/p5-Mail-SpamAssassin Makefile distinfo pkg-plist Message-ID: <20040119184930.GC6433@dragon.nuxi.com> In-Reply-To: <1074530713.53674.9.camel@pav.hide.vol.cz> References: <200401191544.i0JFib85052132@repoman.freebsd.org> <20040119163258.GB4722@dragon.nuxi.com> <359167705.1074533881@andromede.reaumur.absolight.net> <1074530713.53674.9.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 19, 2004 at 05:45:14PM +0100, Pav Lucistnik wrote:
> V po, 19. 01. 2004 v 17:38, Mathieu Arnold p??e:
>
> > |> mat 2004/01/19 07:44:37 PST
> > |>
> > |> FreeBSD ports repository
> > |>
> > |> Modified files:
> > |> mail/p5-Mail-SpamAssassin Makefile distinfo pkg-plist
> > |> Log:
> > |> Update to 2.62
> > |> Have the least thing possible between bsd.port.pre.mk and post.mk
> > |
> > | Please back this out. It is hard to read and find the dependencies. The
> > | Porter's handbook clearly documents where w/in a port's Makefile
> > | {BUILD,RUN}_DEPENDS belong in the Makefile.
> >
> > Do you really mean that every perl port that does this should be changed ?
> > it's the first time someone tells me so.
>
> I don't see any problem with having conditional dependencies specified
> in the very bottom of a Makefile ... even, I like it more this way.
It is against the Porter's Handbook for one, against 10 years of how a
port's Makefile is organized, and they are hard to find -- people read
Makefile's also, not just make(1).
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile.html
Chapter 5 Configuring the Makefile
...
Also, there is a sample Makefile in this handbook, so take a look and
please follow the ordering of variables and sections in that template
to make your port easier for others to read.
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-samplem.html
Chapter 17 A Sample Makefile
...
It is recommended that you follow this format (ordering of variables,
empty lines between sections, etc.). This format is designed so that
the most important information is easy to locate.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040119184930.GC6433>