From owner-svn-src-all@FreeBSD.ORG Tue Nov 24 17:46:59 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 403F51065670; Tue, 24 Nov 2009 17:46:59 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 2F6E88FC08; Tue, 24 Nov 2009 17:46:59 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id nAOHkxYf025389; Tue, 24 Nov 2009 17:46:59 GMT (envelope-from yongari@svn.freebsd.org) Received: (from yongari@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id nAOHkxrP025387; Tue, 24 Nov 2009 17:46:59 GMT (envelope-from yongari@svn.freebsd.org) Message-Id: <200911241746.nAOHkxrP025387@svn.freebsd.org> From: Pyun YongHyeon Date: Tue, 24 Nov 2009 17:46:59 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r199761 - head/sys/dev/bge X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2009 17:46:59 -0000 Author: yongari Date: Tue Nov 24 17:46:58 2009 New Revision: 199761 URL: http://svn.freebsd.org/changeset/base/199761 Log: BGE_FLAG_40BIT_BUG should be set before creating DMA tags. Pointy hat to: yongari Modified: head/sys/dev/bge/if_bge.c Modified: head/sys/dev/bge/if_bge.c ============================================================================== --- head/sys/dev/bge/if_bge.c Tue Nov 24 17:15:22 2009 (r199760) +++ head/sys/dev/bge/if_bge.c Tue Nov 24 17:46:58 2009 (r199761) @@ -2665,6 +2665,13 @@ bge_attach(device_t dev) } /* + * The 40bit DMA bug applies to the 5714/5715 controllers and is + * not actually a MAC controller bug but an issue with the embedded + * PCIe to PCI-X bridge in the device. Use 40bit DMA workaround. + */ + if (BGE_IS_5714_FAMILY(sc) && (sc->bge_flags & BGE_FLAG_PCIX)) + sc->bge_flags |= BGE_FLAG_40BIT_BUG; + /* * Allocate the interrupt, using MSI if possible. These devices * support 8 MSI messages, but only the first one is used in * normal operation. @@ -2798,13 +2805,6 @@ bge_attach(device_t dev) #ifdef DEVICE_POLLING ifp->if_capabilities |= IFCAP_POLLING; #endif - /* - * The 40bit DMA bug applies to the 5714/5715 controllers and is - * not actually a MAC controller bug but an issue with the embedded - * PCIe to PCI-X bridge in the device. Use 40bit DMA workaround. - */ - if (BGE_IS_5714_FAMILY(sc) && (sc->bge_flags & BGE_FLAG_PCIX)) - sc->bge_flags |= BGE_FLAG_40BIT_BUG; /* * 5700 B0 chips do not support checksumming correctly due