Date: Tue, 31 Aug 2010 14:23:17 +0200 (CEST) From: Florian Smeets <flo@kasimir.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: melifaro@ipfw.ru Subject: ports/150146: [PATCH] net/igmpproxy: fix rc script Message-ID: <20100831122317.9DDA45C83@mail.solomo.de> Resent-Message-ID: <201008311230.o7VCU6Yb063410@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 150146
>Category: ports
>Synopsis: [PATCH] net/igmpproxy: fix rc script
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Aug 31 12:30:05 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Florian Smeets
>Release: FreeBSD 8.1-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD mail.solomo.de 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #1: Fri Jul 23 15:47:09 UTC 2010
>Description:
- as of version 0.1 one needs to specify the config file on the command line
- igmpproxy does not daemonize itself so use /usr/sbin/daemon to start it
- little cleanups based on mailinglist feedback by doubg for other rc scripts
- add shutdown KEYWORD
- set default variables after load_rc_config
Port maintainer (melifaro@ipfw.ru) is cc'd.
Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:
--- igmpproxy-0.1_1,1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/net/igmpproxy.orig/Makefile /usr/ports/net/igmpproxy/Makefile
--- /usr/ports/net/igmpproxy.orig/Makefile 2010-08-31 13:36:51.000000000 +0200
+++ /usr/ports/net/igmpproxy/Makefile 2010-08-31 13:51:16.000000000 +0200
@@ -7,6 +7,7 @@
PORTNAME= igmpproxy
PORTVERSION= 0.1
+PORTREVISION= 1
PORTEPOCH= 1
CATEGORIES= net
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}
diff -ruN --exclude=CVS /usr/ports/net/igmpproxy.orig/files/igmpproxy.in /usr/ports/net/igmpproxy/files/igmpproxy.in
--- /usr/ports/net/igmpproxy.orig/files/igmpproxy.in 2010-08-31 13:36:51.000000000 +0200
+++ /usr/ports/net/igmpproxy/files/igmpproxy.in 2010-08-31 14:11:53.000000000 +0200
@@ -5,19 +5,28 @@
# PROVIDE: igmpproxy
# REQUIRE: NETWORKING
+# KEYWORD: shutdown
# The following variables are provided to control startup of igmpproxy
# rc configuration file (eg /etc/rc.conf):
# igmpproxy_enable (bool): Set to "NO" by default.
# Set it to "YES" to enable igmpproxy.
+# igmpproxy_conf (path): Set full path to configuration file.
+# Default is "%%PREFIX%%/etc/igmpproxy.conf"
. /etc/rc.subr
name="igmpproxy"
rcvar=`set_rcvar`
-command="%%PREFIX%%/sbin/${name}"
+procname="%%PREFIX%%/sbin/${name}"
+command=/usr/sbin/daemon
required_files="%%PREFIX%%/etc/igmpproxy.conf"
-igmpproxy_enable=${igmpproxy_enable-"NO"}
load_rc_config $name
+
+igmpproxy_enable=${igmpproxy_enable-"NO"}
+igmpproxy_conf=${igmpproxy_config-"%%PREFIX%%/etc/igmpproxy.conf"}
+
+command_args=" -cf $procname $igmpproxy_conf"
+
run_rc_command "$1"
--- igmpproxy-0.1_1,1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100831122317.9DDA45C83>