From owner-svn-src-head@FreeBSD.ORG Wed Jun 24 01:48:46 2015 Return-Path: Delivered-To: svn-src-head@nevdull.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7DF40FD0; Wed, 24 Jun 2015 01:48:46 +0000 (UTC) (envelope-from araujo@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5F5A8AE8; Wed, 24 Jun 2015 01:48:46 +0000 (UTC) (envelope-from araujo@FreeBSD.org) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id t5O1mkqA004061; Wed, 24 Jun 2015 01:48:46 GMT (envelope-from araujo@FreeBSD.org) Received: (from araujo@localhost) by svn.freebsd.org (8.14.9/8.14.9/Submit) id t5O1mjCp004060; Wed, 24 Jun 2015 01:48:46 GMT (envelope-from araujo@FreeBSD.org) Message-Id: <201506240148.t5O1mjCp004060@svn.freebsd.org> X-Authentication-Warning: svn.freebsd.org: araujo set sender to araujo@FreeBSD.org using -f From: Marcelo Araujo Date: Wed, 24 Jun 2015 01:48:45 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r284745 - head/lib/libugidfw X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jun 2015 01:48:46 -0000 Author: araujo (ports committer) Date: Wed Jun 24 01:48:44 2015 New Revision: 284745 URL: https://svnweb.freebsd.org/changeset/base/284745 Log: Set some internal helpers as static and initialize few variables to silence CLANG WARNINGS. BUMP SHLIB_MAJOR version as the ABI potentially changed. Also run an 'exp run' to double check if any external project are using those functions. Thanks antoine@. PR: 200807 Differential Revision: D2775 Reviewed by: kib, ngie Modified: head/lib/libugidfw/Makefile head/lib/libugidfw/ugidfw.c Modified: head/lib/libugidfw/Makefile ============================================================================== --- head/lib/libugidfw/Makefile Wed Jun 24 01:34:35 2015 (r284744) +++ head/lib/libugidfw/Makefile Wed Jun 24 01:48:44 2015 (r284745) @@ -1,7 +1,7 @@ # $FreeBSD$ LIB= ugidfw -SHLIB_MAJOR= 4 +SHLIB_MAJOR= 5 SRCS= ugidfw.c INCS= ugidfw.h Modified: head/lib/libugidfw/ugidfw.c ============================================================================== --- head/lib/libugidfw/ugidfw.c Wed Jun 24 01:34:35 2015 (r284744) +++ head/lib/libugidfw/ugidfw.c Wed Jun 24 01:48:44 2015 (r284745) @@ -505,7 +505,7 @@ truncated: return (-1); } -int +static int bsde_parse_uidrange(char *spec, uid_t *min, uid_t *max, size_t buflen, char *errstr){ struct passwd *pwd; @@ -554,7 +554,7 @@ bsde_parse_uidrange(char *spec, uid_t *m return (0); } -int +static int bsde_parse_gidrange(char *spec, gid_t *min, gid_t *max, size_t buflen, char *errstr){ struct group *grp; @@ -603,7 +603,7 @@ bsde_parse_gidrange(char *spec, gid_t *m return (0); } -int +static int bsde_parse_subject(int argc, char *argv[], struct mac_bsdextended_subject *subject, size_t buflen, char *errstr) { @@ -612,7 +612,7 @@ bsde_parse_subject(int argc, char *argv[ char *endp; uid_t uid_min, uid_max; gid_t gid_min, gid_max; - int jid; + int jid = 0; size_t len; long value; @@ -720,7 +720,7 @@ bsde_parse_subject(int argc, char *argv[ return (0); } -int +static int bsde_parse_type(char *spec, int *type, size_t buflen, char *errstr) { size_t len; @@ -764,7 +764,7 @@ bsde_parse_type(char *spec, int *type, s return (0); } -int +static int bsde_parse_fsid(char *spec, struct fsid *fsid, size_t buflen, char *errstr) { size_t len; @@ -781,15 +781,15 @@ bsde_parse_fsid(char *spec, struct fsid return (0); } -int +static int bsde_parse_object(int argc, char *argv[], struct mac_bsdextended_object *object, size_t buflen, char *errstr) { int not_seen, flags; int current, neg, nextnot; + int type; uid_t uid_min, uid_max; gid_t gid_min, gid_max; - int type; struct fsid fsid; size_t len; @@ -797,6 +797,7 @@ bsde_parse_object(int argc, char *argv[] flags = 0; neg = 0; nextnot = 0; + type = 0; if (strcmp("not", argv[current]) == 0) { not_seen = 1; @@ -1101,7 +1102,7 @@ bsde_get_mib(const char *string, int *na return (0); } -int +static int bsde_check_version(size_t buflen, char *errstr) { size_t len;