Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Feb 2017 20:47:05 +0200
From:      liuyingdong <liuyingdong@huawei.com>
To:        roger freebsd xen maintainer <roger.pau@citrix.com>, <freebsd-xen@freebsd.org>
Subject:   Re: Multiple patch review
Message-ID:  <a961c0f0-29de-bdde-36bf-4f8394cf1c1c@huawei.com>
In-Reply-To: <af666107-9281-fb57-5d52-bf637def780c@huawei.com>
References:  <af666107-9281-fb57-5d52-bf637def780c@huawei.com>

next in thread | previous in thread | raw e-mail | index | archive | help
> 发件人: Roger Pau Monné [mailto:roger.pau@citrix.com]
> 发送时间: 2017年2月15日 14:32
> 收件人: Liuyingdong <liuyingdong@huawei.com>
> 抄送: freebsd-xen@freebsd.org;
> 主题: Re: Multiple patch review (was: Re:[PATCH]netfront: need release all resources) after adding and removing NICs time and again
> 
> On Wed, Feb 15, 2017 at 02:06:36PM +0200, liuyingdong wrote:
>> On 2017/2/13 12:05, liuyingdong wrote:
>>> 发件人: roger.pau@citrix.com [mailto:roger.pau@citrix.com]
>>> 发送时间: 2017年2月10日 17:12
>>> 收件人: Liuyingdong <liuyingdong@huawei.com>
>>> 抄送: freebsd-xen@freebsd.org; Suoben <suoben@huawei.com>; Zhaojun
>>> (Euler) <zhao.zhaojun@huawei.com>; Wanglinkai
>>> <wanglinkai@huawei.com>; chuzhaosong <chuzhaosong@huawei.com>;
>>> Wangchunfeng (Ivan) <chunfeng.wang@huawei.com>; Gaoxiaodong (Leo)
>>> <leo.gaoxiaodong@huawei.com>
>>> 主题: Multiple patch review (was: Re:[PATCH]netfront: need
>>> release all resources) after adding and removing NICs time and again
>>>
>>> On Tue, Feb 07, 2017 at 04:55:34PM +0000, Liuyingdong wrote:
>>>> Hi Roger,
>>>>          I am so sorry and please review tne below URL:
>>>> https://lists.freebsd.org/pipermail/freebsd-xen/2017-February/002957.html
>>>
>>> Hello,
>>>
>>> Thanks for the patches, and sorry for the delay. It seems like you have not applied some of my comments, so I will have to re-post them here. If some of the comments don't apply for whatever reason, please reply back and explain why, or else this is not going to progress in an useful way for any of us.
>>>
>>> I would also request you to look into using `git send-email`, reviewing your patches as attachments is not very comfortable. Or else, you could create an account to https://reviews.freebsd.org/ and upload the patches there assigning me as a reviewer.
>>>
>> I have created an account to https://reviews.freebsd.org/ and uploaded the patches but I cann't assign you as a reviewer so I assign visible to All Users.
>> The three modified patches are as follows:
>> 1.https://reviews.freebsd.org/differential/diff/25207/
>> 2.https://reviews.freebsd.org/differential/diff/25208/
>> 3.https://reviews.freebsd.org/differential/diff/25209/
> 
> You need to finish creating the revision, click on "Continue", and add a title/description and reviewers, see https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface for more information.
> 
Thank you for the time and patience you devoted to guide me how to create a revision. I have created three revisions and please review again.
https://reviews.freebsd.org/D9635
https://reviews.freebsd.org/D9638
https://reviews.freebsd.org/D9639
> Roger.
> 

Thanks, Terry.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a961c0f0-29de-bdde-36bf-4f8394cf1c1c>