Date: Tue, 19 May 2015 15:06:40 -0400 From: John Baldwin <jhb@freebsd.org> To: src-committers@freebsd.org Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283120 - in head: lib/libpmc sys/dev/hwpmc sys/sys Message-ID: <1908963.8Har9SZnS7@ralph.baldwin.cx> In-Reply-To: <201505191858.t4JIwJft016661@svn.freebsd.org> References: <201505191858.t4JIwJft016661@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, May 19, 2015 06:58:19 PM John Baldwin wrote: > Author: jhb > Date: Tue May 19 18:58:18 2015 > New Revision: 283120 > URL: https://svnweb.freebsd.org/changeset/base/283120 > > Log: > Use fixed enum values for PMC_CLASSES(). > > This removes one of the frequent causes of ABI breakage when new CPU > types are added to hwpmc(4). > > Differential Revision: https://reviews.freebsd.org/D2586 > Reviewed by: davide, emaste, gnn (earlier version) > MFC after: 2 weeks The ABI was already broken today with the ARMv8 counters. Merging this to stable will break the ABI there as well. Since PMC_SOFT always gets renumbered it always breaks pmcccontrol -L when this enum is updated. I believe it has already been broken in once stable/10. My preference would be that we only MFC this the next time we want to add a new class to 10 to avoid being too disruptive. At the time the new class is added, then this change could be merged as well. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1908963.8Har9SZnS7>