Date: Wed, 17 Dec 2014 12:48:37 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: svn-src-head@freebsd.org, Ed Schouten <ed@80386.nl>, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric <dim@FreeBSD.org> Subject: Re: svn commit: r275819 - in head/lib/msun: ld128 ld80 src Message-ID: <87FF0FD4-EEF2-4264-9CBA-4B3A46E52FCB@gmail.com> In-Reply-To: <20141217191235.GA89501@troutmask.apl.washington.edu> References: <201412160921.sBG9LvFY064961@svn.freebsd.org> <20141216162055.GA64273@troutmask.apl.washington.edu> <CAJOYFBAAe_3psxdDC1Oq0%2BW=9T4qnSDK=tST3pP6q1iBpgME1w@mail.gmail.com> <20141217191235.GA89501@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_FF39F2E8-E98B-4A72-85A5-9B63BDF7ABBD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Dec 17, 2014, at 11:12, Steve Kargl = <sgk@troutmask.apl.washington.edu> wrote: > On Wed, Dec 17, 2014 at 04:30:32PM +0100, Ed Schouten wrote: =85 >>> This comment isn't true! These functions pre-date C11 by years. >>> See r151865. These functions were designed to deal with gcc's >>> poorly implemented I. See the paragraph above your comment. >>=20 >> Keep in mind that the phrasing is intended to say that CMPLX*() and >> friends are part of C11. Those do not pre-date C11. >=20 > The phrasing is wrong. cpack[fl] came at least 6 years before > C11 and were designed to work around defects in C99. CMPLX[FL] > were introduced into C11 to address those defects. Changing > cpack[fl] to CMPLX[FL] and claiming that the functions are=20 > modeled after the C11 macros is wrong (unless the meaning of > "before" and "after" have changed). Hi Dimitry/Ed/Steve, Does it make sense to take the logic that Ed added and guard it = with a conditional so people building the functions can use the C+11 = definitions instead of the C99 definitions? This could preserve the old = behavior for folks who don=92t have C+11 capable compilers, but would = allow us (and others) who do via clang or newer versions of gcc to use = the new C+11 idioms, similar to some of the other macros in sys/cdefs.h, = et al. Thank you! --Apple-Mail=_FF39F2E8-E98B-4A72-85A5-9B63BDF7ABBD Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUkewlAAoJEMZr5QU6S73eu1MH/37z7YWekKpRkG2NnFM7aHff ehRl1k6bAlMSraKnX33h/T6klaXfx0RUNkxbsA03s/Ulzf5Nyj5N/u9zE9dDK77D 5E1jorbtvbv4y6DWQQFb/12JufK5i79vDTkeVgE6+jR8IICdAMkCAInQVMH1g8VU I4q2HiEWsLErpWZSacDlX37aum5OZk3829ljlP0/VVMOr31xx1hAKtlWSKWz1OSZ yOXpnjBESo01dcXdW+Gnt7SPUki0BseE4VC/rl9pE9HDX2lzO16atU7R2Et58vTM 2obgnKVIQ+0ym6p/zH5GcOeXIbSZrEYjmJvHtDSifAZe/avY7S26qJZapxXjvrI= =bGwA -----END PGP SIGNATURE----- --Apple-Mail=_FF39F2E8-E98B-4A72-85A5-9B63BDF7ABBD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87FF0FD4-EEF2-4264-9CBA-4B3A46E52FCB>