From owner-svn-src-head@FreeBSD.ORG Wed Dec 17 20:48:40 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3BAAD1CD; Wed, 17 Dec 2014 20:48:40 +0000 (UTC) Received: from mail-pa0-x234.google.com (mail-pa0-x234.google.com [IPv6:2607:f8b0:400e:c03::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F414F1A63; Wed, 17 Dec 2014 20:48:39 +0000 (UTC) Received: by mail-pa0-f52.google.com with SMTP id eu11so17172185pac.39 for ; Wed, 17 Dec 2014 12:48:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=gpL+TGJub9+S0cgRvUjQbIalUoxtsMnSzv1UvSh8p3M=; b=Vkz5jw1x02TGnZRKpu6N79rpparHHRk7UQ9oVlHmEKclJY3jZqT1+bMoseawmlBe6K 103kV8dNgrQmkR6YTtqPifkKnSzAF8JH9POLs1gR2SV1X59oeYLc3+keLdAdz2Vu9U7H MHUm8DB8Nq3NoKhvh8uPXNVOA1G805m5oZ1v5SsuVqf6D6qErBu/ytxYCcPGHsMwpXmC alzikZ2Bh7+3HOSDmiXGWlp8m8kQ6iolr6UkU8E0hquyKsVm9ZF6zmA7kVgjp6uGQBJ+ 2sOjGQRaPOWstdW7wEQaF9FtMOQvccAeQkYjWKjcfRa1urIWSG7luJBItn5Aza7K8SY7 J+WA== X-Received: by 10.66.226.167 with SMTP id rt7mr72574691pac.12.1418849319519; Wed, 17 Dec 2014 12:48:39 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:4e8:e4bf:d5e5:12e3? ([2601:8:ab80:7d6:4e8:e4bf:d5e5:12e3]) by mx.google.com with ESMTPSA id c17sm4812394pdl.6.2014.12.17.12.48.38 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 17 Dec 2014 12:48:38 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_FF39F2E8-E98B-4A72-85A5-9B63BDF7ABBD"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r275819 - in head/lib/msun: ld128 ld80 src From: Garrett Cooper In-Reply-To: <20141217191235.GA89501@troutmask.apl.washington.edu> Date: Wed, 17 Dec 2014 12:48:37 -0800 Message-Id: <87FF0FD4-EEF2-4264-9CBA-4B3A46E52FCB@gmail.com> References: <201412160921.sBG9LvFY064961@svn.freebsd.org> <20141216162055.GA64273@troutmask.apl.washington.edu> <20141217191235.GA89501@troutmask.apl.washington.edu> To: Steve Kargl X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, Ed Schouten , svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2014 20:48:40 -0000 --Apple-Mail=_FF39F2E8-E98B-4A72-85A5-9B63BDF7ABBD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Dec 17, 2014, at 11:12, Steve Kargl = wrote: > On Wed, Dec 17, 2014 at 04:30:32PM +0100, Ed Schouten wrote: =85 >>> This comment isn't true! These functions pre-date C11 by years. >>> See r151865. These functions were designed to deal with gcc's >>> poorly implemented I. See the paragraph above your comment. >>=20 >> Keep in mind that the phrasing is intended to say that CMPLX*() and >> friends are part of C11. Those do not pre-date C11. >=20 > The phrasing is wrong. cpack[fl] came at least 6 years before > C11 and were designed to work around defects in C99. CMPLX[FL] > were introduced into C11 to address those defects. Changing > cpack[fl] to CMPLX[FL] and claiming that the functions are=20 > modeled after the C11 macros is wrong (unless the meaning of > "before" and "after" have changed). Hi Dimitry/Ed/Steve, Does it make sense to take the logic that Ed added and guard it = with a conditional so people building the functions can use the C+11 = definitions instead of the C99 definitions? This could preserve the old = behavior for folks who don=92t have C+11 capable compilers, but would = allow us (and others) who do via clang or newer versions of gcc to use = the new C+11 idioms, similar to some of the other macros in sys/cdefs.h, = et al. Thank you! --Apple-Mail=_FF39F2E8-E98B-4A72-85A5-9B63BDF7ABBD Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUkewlAAoJEMZr5QU6S73eu1MH/37z7YWekKpRkG2NnFM7aHff ehRl1k6bAlMSraKnX33h/T6klaXfx0RUNkxbsA03s/Ulzf5Nyj5N/u9zE9dDK77D 5E1jorbtvbv4y6DWQQFb/12JufK5i79vDTkeVgE6+jR8IICdAMkCAInQVMH1g8VU I4q2HiEWsLErpWZSacDlX37aum5OZk3829ljlP0/VVMOr31xx1hAKtlWSKWz1OSZ yOXpnjBESo01dcXdW+Gnt7SPUki0BseE4VC/rl9pE9HDX2lzO16atU7R2Et58vTM 2obgnKVIQ+0ym6p/zH5GcOeXIbSZrEYjmJvHtDSifAZe/avY7S26qJZapxXjvrI= =bGwA -----END PGP SIGNATURE----- --Apple-Mail=_FF39F2E8-E98B-4A72-85A5-9B63BDF7ABBD--