Date: Wed, 18 Apr 2001 08:26:25 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/sys/kern kern_clock.c Message-ID: <Pine.BSF.4.21.0104180800580.12760-100000@besplex.bde.org> In-Reply-To: <XFMail.010417110037.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 17 Apr 2001, John Baldwin wrote: > On 17-Apr-01 John Baldwin wrote: > > jhb 2001/04/17 10:53:37 PDT > > > > Modified files: > > sys/kern kern_clock.c > > Log: > > Fix an old bug related to BETTER_CLOCK. Call forward_*clock if SMP > > and __i386__ are defined rather than if SMP and BETTER_CLOCK are defined. > > The removal of BETTER_CLOCK would have broken this except that kern_clock.c > > doesn't include <machine/smptests.h>, so it doesn't see the definition of > > BETTER_CLOCK, and forward_*clock aren't called, even on 4.x. This seems to > > fix the problem where a n-way SMP system would see 100 * n clk interrupts > > and 128 * n rtc interrupts. > > This should probably be fixed in 4.x at some point, as it means clock > interrupts aren't getting forwarded to other CPU's. Then again, some parts of There is no problem in RELENG_4, since <machine/smptests.h> is (bogusly) included in <machine/lock.h>, which is (non-bogusly) included in <sys/lock.h>, which is (bogusly) included in kern_clock.c. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0104180800580.12760-100000>