Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 6 Nov 2006 19:50:30 GMT
From:      Sam Leffler <sam@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 109371 for review
Message-ID:  <200611061950.kA6JoUHO088383@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=109371

Change 109371 by sam@sam_ebb on 2006/11/06 19:49:43

	replace magic constants with symbolic names

Affected files ...

.. //depot/projects/arm/src/sys/arm/xscale/ixp425/ixp425reg.h#4 edit
.. //depot/projects/arm/src/sys/arm/xscale/ixp425/uart_bus_ixp425.c#5 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/xscale/ixp425/ixp425reg.h#4 (text+ko) ====

@@ -134,6 +134,10 @@
 
 #define	IXP425_UART_FREQ	14745600
 
+#define	IXP425_UART_IER		0x01	/* interrupt enable register */
+#define	IXP425_UART_IER_RTOIE	0x10	/* receiver timeout interrupt enable */
+#define	IXP425_UART_IER_UUE	0x40	/* UART Unit enable */
+
 /*#define	IXP4XX_COM_NPORTS	8*/
 
 /*

==== //depot/projects/arm/src/sys/arm/xscale/ixp425/uart_bus_ixp425.c#5 (text+ko) ====

@@ -81,8 +81,9 @@
 	 * uart_ns8250 carefully avoids touching these bits so we can
 	 * just set them here and proceed.  But this is fragile...
 	 */
-	bus_space_write_4(&ixp425_a4x_bs_tag, device_get_unit(dev) == 0 ?
-	    IXP425_UART0_VBASE : IXP425_UART1_VBASE, REG_IER, 0x50);
+	bus_space_write_4(&ixp425_a4x_bs_tag,
+	    device_get_unit(dev) == 0 ? IXP425_UART0_VBASE : IXP425_UART1_VBASE,
+	    IXP425_UART_IER, IXP425_UART_IER_UUE | IXP425_UART_IER_RTOIE);
 	return(uart_bus_probe(dev, 0, IXP425_UART_FREQ, 0, 0));
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611061950.kA6JoUHO088383>