From owner-svn-src-head@FreeBSD.ORG Tue Feb 24 10:27:25 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 43422106566C; Tue, 24 Feb 2009 10:27:25 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 186048FC13; Tue, 24 Feb 2009 10:27:25 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id 93DC946B65; Tue, 24 Feb 2009 05:27:24 -0500 (EST) Date: Tue, 24 Feb 2009 10:27:24 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Yuriy Tsibizov In-Reply-To: Message-ID: References: <200902232257.n1NMvtgt042002@svn.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Kip Macy Subject: RE: svn commit: r188962 - head/sys/netinet X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2009 10:27:25 -0000 On Tue, 24 Feb 2009, Yuriy Tsibizov wrote: >> In in_rtqkill(), assert the radix head lock, and pass RTF_RNH_LOCKED >> to in_rtrequest(); the radix head lock is already acquired before >> rnh_walktree is called in in_rtqtimo_one(). This avoids a recursive >> acquisition that is no longer permitted in 8.x due to use >> of an rwlock >> for the radix head lock. >> >> Reported by: dikshie >> MFC after: 3 days > Will it fix this panic (Kip promised to fix it, if he had time): > > _rw_wlock_hard: recursing but non-recursive rw radix node head @ > /usr/src/sys/net/route.c:831 > > exclusive rw radix node head (radix node head) r = 0 (0xc57fd280) locked @ > /usr/src/sys/netinet/in_rmx.c:275 Yes, this should eb the same problem. If it's not (i.e., it still panics), please let me know. Robert N M Watson Computer Laboratory University of Cambridge > > db:0:kdb.enter.panic> bt > Tracing pid 12 tid 100009 td 0xc5592480 > kdb_enter(c0becf98,c0becf98,c0bec9a4,c52bcaa4,1,...) at kdb_enter+0x3a > panic(c0bec9a4,c0b7d2d5,c0bf30f2,c0bfc97f,33f,...) at panic+0x136 > _rw_wlock_hard(c57fd280,c5592480,c0bfc97f,33f,0,...) at > _rw_wlock_hard+0x66 > _rw_wlock(c57fd280,c0bfc97f,33f,c08436d8,c5cecb40,...) at _rw_wlock+0xae > rtrequest1_fib(2,c52bcb4c,0,0,0,...) at rtrequest1_fib+0x95 > rtrequest_fib(2,c597d780,c597d790,0,40017,...) at rtrequest_fib+0x5e > in_rtrequest(2,c597d780,c597d790,0,40017,...) at in_rtrequest+0x3b > in_rtqkill(c5b25000,c52bcc1c,c57fd200,c57fd280,0,...) at in_rtqkill+0x7f > rn_walktree(c57fd200,c0929c80,c52bcc1c,c57fd300,0,...) at > rn_walktree+0x65 > in_rtqtimo(c57fd200,0,c0bee33f,176,c0d40094,...) at in_rtqtimo+0xb0 > softclock(c0d40060,c52bccc8,c082c134,c0d44400,c5590db8,...) at > softclock+0x24a > intr_event_execute_handlers(c554b7ec,c5590d80,c0be928c,4dd,c5590df0,...) > at intr_event_execute_handlers+0x125 > ithread_loop(c554a0f0,c52bcd38,c0be9005,32d,c554b7ec,...) at > ithread_loop+0x9f > fork_exit(c081ae30,c554a0f0,c52bcd38) at fork_exit+0xb8 > fork_trampoline() at fork_trampoline+0x8 > > Yuriy. > >