From owner-cvs-all  Sun Feb 23  3:29:47 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id F11C137B401; Sun, 23 Feb 2003 03:29:40 -0800 (PST)
Received: from dilbert.robbins.dropbear.id.au (098.b.003.mel.iprimus.net.au [210.50.32.98])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 893E043FAF; Sun, 23 Feb 2003 03:29:37 -0800 (PST)
	(envelope-from tim@robbins.dropbear.id.au)
Received: from dilbert.robbins.dropbear.id.au (4fajjfdqoi2ev244@localhost [127.0.0.1])
	by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6) with ESMTP id h1NBTT2c027669;
	Sun, 23 Feb 2003 22:29:30 +1100 (EST)
	(envelope-from tim@dilbert.robbins.dropbear.id.au)
Received: (from tim@localhost)
	by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6/Submit) id h1NBTSdQ027668;
	Sun, 23 Feb 2003 22:29:28 +1100 (EST)
	(envelope-from tim)
Date: Sun, 23 Feb 2003 22:29:28 +1100
From: Tim Robbins <tjr@FreeBSD.org>
To: Poul-Henning Kamp <phk@FreeBSD.org>
Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys time.h src/sys/kern kern_time.c
Message-ID: <20030223222928.A26996@dilbert.robbins.dropbear.id.au>
References: <200302231018.h1NAIVaV048679@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <200302231018.h1NAIVaV048679@repoman.freebsd.org>; from phk@FreeBSD.org on Sun, Feb 23, 2003 at 02:18:31AM -0800
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sun, Feb 23, 2003 at 02:18:31AM -0800, Poul-Henning Kamp wrote:

> phk         2003/02/23 02:18:31 PST
> 
>   Modified files:
>     sys/sys              time.h 
>     sys/kern             kern_time.c 
>   Log:
>   Implement CLOCK_MONOTONIC.

I think there is a typo here:

	if (uap->clock_id != CLOCK_REALTIME)
		nanotime(&ats);
	else if (uap->clock_id != CLOCK_MONOTONIC)
		nanouptime(&ats);

Shouldn't it be...

	if (uap->clock_id == CLOCK_REALTIME)
		nanotime(&ats);
	else if (uap->clock_id == CLOCK_MONOTONIC)
		nanouptime(&ats);
	else
		return (EINVAL);

Thanks for doing this, though. I'll add CLOCK_PROF and CLOCK_VIRTUAL
as soon as -current has stabilised a bit.


Tim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message