Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 May 2002 16:07:42 -0700 (PDT)
From:      Adam Migus <amigus@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 11069 for review
Message-ID:  <200205092307.g49N7gm68486@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=11069

Change 11069 by amigus@amigus_ganymede on 2002/05/09 16:07:03

	Forgot to fdrop() if fget() succeeded.  Doh!

Affected files ...

... //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#139 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#139 (text+ko) ====

@@ -1721,7 +1721,7 @@
 
 	error = fget(td, SCARG(uap, fd), &fp);
 	if (error)
-		goto out;
+		goto out2;
 
 	if(fp->f_type != DTYPE_SOCKET) {
 		error = EINVAL;
@@ -1734,9 +1734,9 @@
 
 	if (error == 0)
 		error = copyout(&label, SCARG(uap, mac_p), sizeof(label));
+out:
  	fdrop(fp, td);
-
-out:
+out2:
 	mtx_unlock(&Giant);
 	return (error);
 }

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205092307.g49N7gm68486>