From owner-freebsd-scsi@FreeBSD.ORG Fri Oct 4 16:41:25 2013 Return-Path: Delivered-To: FreeBSD-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id AA3A0680 for ; Fri, 4 Oct 2013 16:41:25 +0000 (UTC) (envelope-from scott4long@yahoo.com) Received: from nm36.bullet.mail.bf1.yahoo.com (nm36.bullet.mail.bf1.yahoo.com [72.30.239.5]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EF1032870 for ; Fri, 4 Oct 2013 16:41:24 +0000 (UTC) Received: from [98.139.212.151] by nm36.bullet.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 16:41:15 -0000 Received: from [98.139.211.192] by tm8.bullet.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 16:41:15 -0000 Received: from [127.0.0.1] by smtp201.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 16:41:15 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1380904875; bh=eQN8jI0bwagQHt0fwSHAbBb1u3wWX2d2LFRlcydk2sg=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer; b=K4QTXFpZdJSzoHZMAaNpimDEpQNt39nMMX8bokUPPQInav3ckFc5VexSbmFISfj7TZBgQvcqSA48eSqAxH+MS+/0y6QMIni1r1fevCi7Nu1LHSLVrQjzRu/eaqOqbZ4HGVzGBGQPoO7AJj4UgEzo9+GGi/RZoe1GqGgnetgdCwg= X-Yahoo-Newman-Id: 903656.84265.bm@smtp201.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: lG._fNkVM1nR4XdNcZeLziWHELQWNCncsFPhHbpsKaFnKfi 0wgWh3aOMQb7n8xv56WVMEjRQHyUuCTq1F5YckYEPduQZmo3PrKxvo6NaeM4 HzzLMhJWzr2PVxcwWa0xYmf2wFswjyACLnWg3yfWpWE0RprvmfDT8PrA02KX r.sj5_6OCrlTcwJYMBhh1X4zh9uB_i8zN8ttVDIqXKfO2gbElGIPLSepMetF W_AcYdhame66ZWF.pumRxanypPmlMmCJaGyD.nwQ0_rWjTKbkDb0uXt8WJLR .NEma_GcZOziEvadxTW6I1RCuHjlgAXlfvbQEtErbwZ1T0X4CQV5VzVXkksb EIjyxxUYWaHzUdF68aMpA5AMbSqYTLxpB5024w0YLKbUCuyH9DizE380p03x S0GZNVRD1aouzULYPj8aW8TmcRWxCN8nUyRtr85260wp7QB0EufD9mxykeey KrckC6PsFrmYuBv0VL5IRIwvLsWNVgW61dTONbBKyaikCNdq_KJbmTeOPeS5 kXkq0EQ_ax.6oJ.pUXi_s0AQZlNeD9Td48RspHN2saiJ0ijhQ0bumEtl9Rw- - X-Yahoo-SMTP: clhABp.swBB7fs.LwIJpv3jkWgo2NU8- X-Rocket-Received: from lgmac-jluy.corp.netflix.com (scott4long@69.53.237.126 with ) by smtp201.mail.bf1.yahoo.com with SMTP; 04 Oct 2013 09:41:15 -0700 PDT Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: pci_alloc_msi is always called, is this bad? From: Scott Long In-Reply-To: <20131004161947.GU41229@kib.kiev.ua> Date: Fri, 4 Oct 2013 10:41:13 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <80AF177A-215F-49B7-8254-8FD896945849@yahoo.com> References: <20131003194704.GG41229@kib.kiev.ua> <1380902209.2621.11.camel@localhost> <94C7BB39-A287-44D4-9992-E8DAE83CE6D4@yahoo.com> <20131004161947.GU41229@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1510) Cc: "FreeBSD-scsi@freebsd.org" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 16:41:25 -0000 On Oct 4, 2013, at 10:19 AM, Konstantin Belousov = wrote: > On Fri, Oct 04, 2013 at 10:05:18AM -0600, Scott Long wrote: >> It used to be that gcc would generate code that would conditionally = execute the second clause only if the first clause were true. If that's = not longer the case (with gcc and/or clang), then I bet that UDF will = break due to this: >>=20 >> /* >> * Check to see if the fid is fragmented. The first test >> * ensures that we don't wander off the end of the buffer >> * looking for the l_iu and l_fi fields. >> */ >> if (ds->off + UDF_FID_SIZE > ds->size || >> ds->off + le16toh(fid->l_iu) + fid->l_fi + UDF_FID_SIZE > = ds->size){ > Is this some sort of joke ? >=20 > C 'and' and 'or' logical operators are short-circuit. It is not > compiler-depended. Meh, I was young and stupid. The generated code supported the = construct. Scott