From owner-freebsd-stable@FreeBSD.ORG Mon Sep 15 02:38:54 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C1A1CE7; Mon, 15 Sep 2014 02:38:54 +0000 (UTC) Received: from mail-pa0-x22d.google.com (mail-pa0-x22d.google.com [IPv6:2607:f8b0:400e:c03::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8C20F95A; Mon, 15 Sep 2014 02:38:54 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id rd3so5358358pab.32 for ; Sun, 14 Sep 2014 19:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=SLFbOORVXol8AqlgPCyZ/+2K7Duq0FUvyWMOXfbOr0g=; b=cFPw/8t/0UqkJtsDBKbNq236Hi5UxZCy+18dCcMdN1cdVBzBqiXmB/2sJXefC4HnZI PLaGnG9TUSfoKSz88CpOeCM5MjyeMFcXrzoboOSjJ/jFDfXrqein0Tbv8tFdOMNSCemb NCPTRQN6esGDjufCOvnYrCPW1WiwPAiEONSzCBpKl4ILDTCkGgyyp6nJHObFk6ONP2iW 2DDHheVT5vxyCLT9V96bfXuTdkzuZm+TBMzkqiR5Vml349WRGF6dKp1N1Ach2SGKV3K1 pxg8/7MBrz4waQI0qGMDiXOvKl7RKXKz7GMQIkkVqBQGl87vQ9Rue5m2fX29f+3ll5ZS Hoiw== X-Received: by 10.70.100.133 with SMTP id ey5mr465219pdb.153.1410748734061; Sun, 14 Sep 2014 19:38:54 -0700 (PDT) Received: from pyunyh@gmail.com ([106.247.248.2]) by mx.google.com with ESMTPSA id cu3sm9841995pbb.48.2014.09.14.19.38.49 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 14 Sep 2014 19:38:52 -0700 (PDT) From: Yonghyeon PYUN X-Google-Original-From: "Yonghyeon PYUN" Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Mon, 15 Sep 2014 11:38:42 +0900 Date: Mon, 15 Sep 2014 11:38:42 +0900 To: Mike Tancsa Subject: Re: svn commit: r267935 - head/sys/dev/e1000 (with work around?) Message-ID: <20140915023842.GA3440@michelle.fasterthan.com> Reply-To: pyunyh@gmail.com References: <1737288805.35881978.1410642408202.JavaMail.root@uoguelph.ca> <5414DEAA.1060009@sentex.net> <5415F926.80902@sentex.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5415F926.80902@sentex.net> User-Agent: Mutt/1.4.2.3i Cc: Glen Barber , Eric Joyner , Rick Macklem , freebsd-stable , Jack Vogel X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Sep 2014 02:38:54 -0000 On Sun, Sep 14, 2014 at 04:23:02PM -0400, Mike Tancsa wrote: > On 9/14/2014 4:08 PM, Eric Joyner wrote: > >I'll try to, but I can't promise anything soon -- there's a lot of > >10gig/40gig stuff to do. > > Thanks Eric. At first, I thought it was just a certain variant of the > em, but I have found at least two that get wedged. Its pretty easy to > reproduce. > > One other thing I noticed is that the README states, > > "TSO is not supported on 82547 and 82544-based adapters, as well as > older adapters." > If my memory serve me right, this is correct. > Yet, by default its enabled with the driver. Perhaps a check to just > disable TSO for NICs not supported automatically ? The other NIC I can Yes, it should. > recreate the problem with is > > root@backup3:/usr/home/mdtancsa # pciconf -lvcb em0 > em0@pci0:0:25:0: class=0x020000 card=0x34ec8086 chip=0x10ef8086 > rev=0x05 hdr=0x00 > vendor = 'Intel Corporation' > device = '82578DM Gigabit Network Connection' > class = network > subclass = ethernet > bar [10] = type Memory, range 32, base 0xb1a00000, size 131072, > enabled > bar [14] = type Memory, range 32, base 0xb1a25000, size 4096, enabled > bar [18] = type I/O Port, range 32, base 0x2040, size 32, enabled > cap 01[c8] = powerspec 2 supports D0 D3 current D0 > cap 05[d0] = MSI supports 1 message, 64 bit enabled with 1 message > cap 13[e0] = PCI Advanced Features: FLR TP > root@backup3:/usr/home/mdtancsa # > > The odd thing however is that all works fine with the previous rev that > was in the tree. > It looks like previous drivers have a code that conditionally enables TSO for 'MAC rev > 82544 && MAC rev != 82547'. It seems em(4) in CURRENT blindly set TSO for all controllers.