From owner-cvs-all@FreeBSD.ORG Tue Mar 29 01:13:10 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D5EF16A4CE; Tue, 29 Mar 2005 01:13:10 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 551DE43D53; Tue, 29 Mar 2005 01:13:10 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.91] (sam@[66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j2T1D9ms080896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 28 Mar 2005 17:13:09 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <4248AC2B.7090801@errno.com> Date: Mon, 28 Mar 2005 17:15:23 -0800 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050327) X-Accept-Language: en-us, en MIME-Version: 1.0 To: src-committers@FreeBSD.org References: <200503290110.j2T1AlIO092175@repoman.freebsd.org> In-Reply-To: <200503290110.j2T1AlIO092175@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet raw_ip.c tcp_usrreq.c udp_usrreq.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2005 01:13:10 -0000 Sam Leffler wrote: > sam 2005-03-29 01:10:47 UTC > > FreeBSD src repository > > Modified files: > sys/netinet raw_ip.c tcp_usrreq.c udp_usrreq.c > Log: > eliminate extraneous null ptr checks I've not been able to get a definitive answer about whether or not td can be null in these cases but the existing code is wrong one way or the other. Those familiar with the threading code please review. Sam