From owner-cvs-all Sun Jul 23 14:37:49 2000 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 542) id 3430737B8E7; Sun, 23 Jul 2000 14:37:42 -0700 (PDT) Date: Sun, 23 Jul 2000 14:37:42 -0700 From: "Andrey A. Chernov" To: Marcel Moolenaar Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile src/include Makefile src/release Makefile src/release/picobsd/build Makefile.mfs src/release/picobsd/custom Makefile.mfs src/release/picobsd/dial Makefile.mfs src/release/picobsd/install Makefile.mfs Message-ID: <20000723143740.A70582@freebsd.org> References: <200007231633.JAA33796@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4i In-Reply-To: <200007231633.JAA33796@freefall.freebsd.org>; from marcel@FreeBSD.org on Sun, Jul 23, 2000 at 09:33:00AM -0700 Organization: Biomechanoid Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, Jul 23, 2000 at 09:33:00AM -0700, Marcel Moolenaar wrote: > marcel 2000/07/23 09:33:00 PDT > > Modified files: > etc Makefile > include Makefile > release Makefile > release/picobsd/build Makefile.mfs > release/picobsd/custom Makefile.mfs > release/picobsd/dial Makefile.mfs > release/picobsd/install Makefile.mfs > Log: > Backout addition of -L switch to mtree. Using -L breaks the > build process in too many cases. Adding mtree to bootstrap-tools > to solve this breaks the upgrade path because mtree needs a > libc that has strtofflags and fflagstostr. It should be immediately backed out. System security now under risk for admins who use symlinks to /tmp or /var/mail f.e. Proper way of fixing will be to cvs add strtofflags file to mtree subdir. Why to fix the bug by breaking in another place? BTW, I even was not asked before my changes are backed out, it is very bad style for commiter that should be avoided. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message