Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 31 May 2000 17:09:09 -0400
From:      Tim Vanderhoek <vanderh@ecf.utoronto.ca>
To:        Satoshi - Ports Wraith - Asami <asami@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: ports/lang/tcl80/pkg DEINSTALL.tclsh ports/lang/tcl82/pkg          DEINSTALL.tclsh ports/lang/tcl83/pkg DEINSTALL.tclsh
Message-ID:  <20000531170909.B2016@orange>
In-Reply-To: <vqcpuq2pjxc.fsf@silvia.hip.berkeley.edu>; from Satoshi - Ports Wraith - Asami on Wed, May 31, 2000 at 01:02:39PM -0700
References:  <200005311741.KAA54827@freefall.freebsd.org> <vqcpuq2pjxc.fsf@silvia.hip.berkeley.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 31, 2000 at 01:02:39PM -0700, Satoshi - Ports Wraith - Asami wrote:
>  *   Add a DEINSTALL.tclsh everywhere there exists an INSTALL.tclsh.
> 
> Now that I think about it, why aren't these called simply "INSTALL"
> and "DEINSTALL"?  It's not like their usage are conditional or
> something.

Originally, it was because the INSTALL script was used by several
ports but kept only in one place: it added semantic clarity and left
the pkg/* namespace open should an INSTALL script be added that
applied only to, eg., tcl82, but none of the others.

[How to make pkg_add deal with two INSTALL scripts was something I
 planned to leave for the first sucker to run into that problem. :-]

Since the INSTALL script has since managed to cancer itself into two
more places than it originally occupied, I did consider cvs rm'ing all
but the tcl82 version, or, alternatively, asking for a repo-copy to
cancer the script into every tcl port.  However, I think the current
situation is good.  The three most common tcl ports have their own
private copy, and three copies of the file is not too hard to track.

[This is all partly a lie: the _other_ reason it's called
 INSTALL.tclsh is because I tested INSTALL.wish in the same directory,
 and the .extension avoided namespace collisions...  The reason given
 above was the rationalisation I used after reading the original commit
 message...  ;-) ]


> Actually they used to be conditional on the files existing (i.e., ".if
> exists(${PORTSDIR}/lang/tcl80/pkg/INSTALL.tclsh") since people could

Still are.  I hope.  :)

Whoever moved them into ${PKGDIR} for tcl8{2,3} didn't bother removing
the test.  Just as well that way.


-- 
Signature withheld by request of author.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000531170909.B2016>