From owner-cvs-all@FreeBSD.ORG  Mon Apr  5 01:28:51 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0343516A4CE; Mon,  5 Apr 2004 01:28:51 -0700 (PDT)
Received: from cs.rice.edu (cs.rice.edu [128.42.1.30])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CA95543D48; Mon,  5 Apr 2004 01:28:50 -0700 (PDT)
	(envelope-from alc@cs.rice.edu)
Received: from localhost (calypso.cs.rice.edu [128.42.1.127])
	by cs.rice.edu (Postfix) with ESMTP
	id 3CE684ACA8; Mon,  5 Apr 2004 03:28:42 -0500 (CDT)
Received: from cs.rice.edu ([128.42.1.30])
 by localhost (calypso.cs.rice.edu [128.42.1.127]) (amavisd-new, port 10024)
 with LMTP id 08795-01-35; Mon,  5 Apr 2004 03:28:41 -0500 (CDT)
Received: by cs.rice.edu (Postfix, from userid 19572)
	id E153C4AA77; Mon,  5 Apr 2004 03:28:41 -0500 (CDT)
Date: Mon, 5 Apr 2004 03:28:41 -0500
From: Alan Cox <alc@cs.rice.edu>
To: Alfred Perlstein <alfred@freebsd.org>
Message-ID: <20040405082841.GT15786@cs.rice.edu>
References: <200404050454.i354sMEd062597@repoman.freebsd.org>
	<20040405072202.GY26131@elvis.mu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040405072202.GY26131@elvis.mu.org>
User-Agent: Mutt/1.3.28i
X-Virus-Scanned: by amavis-20030616-p7 at cs.rice.edu
cc: Alexander Kabaev <kan@FreeBSD.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm vm_mmap.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 08:28:51 -0000

On Mon, Apr 05, 2004 at 12:22:02AM -0700, Alfred Perlstein wrote:
> This fixes the bug I reported?
> 

Yes, I believe so.  This is the patch that I e-mailed you yesterday.

Alan

> * Alexander Kabaev <kan@FreeBSD.org> [040404 21:54] wrote:
> > kan         2004/04/04 21:54:22 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/vm               vm_mmap.c 
> >   Log:
> >   Delay permission checks for VCHR vnodes until after vnode is locked in
> >   vm_mmap_vnode function, where we can safely check for a special /dev/zero
> >   case. Rev. 1.180 has reordered checks and introduced a regression.
> >   
> >   Submitted by:   alc
> >   Was broken by:  kan
> >   
> >   Revision  Changes    Path
> >   1.187     +7 -2      src/sys/vm/vm_mmap.c
> 
> -- 
> - Alfred Perlstein
> - Research Engineering Development Inc.
> - email: bright@mu.org cell: 408-480-4684