From owner-p4-projects@FreeBSD.ORG Tue Apr 11 19:45:37 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 7E34E16A403; Tue, 11 Apr 2006 19:45:37 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DDD216A402 for ; Tue, 11 Apr 2006 19:45:37 +0000 (UTC) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB80043D49 for ; Tue, 11 Apr 2006 19:45:36 +0000 (GMT) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k3BJjaKm009478 for ; Tue, 11 Apr 2006 19:45:36 GMT (envelope-from imp@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k3BJja8a009475 for perforce@freebsd.org; Tue, 11 Apr 2006 19:45:36 GMT (envelope-from imp@freebsd.org) Date: Tue, 11 Apr 2006 19:45:36 GMT Message-Id: <200604111945.k3BJja8a009475@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to imp@freebsd.org using -f From: Warner Losh To: Perforce Change Reviews Cc: Subject: PERFORCE change 95016 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2006 19:45:37 -0000 http://perforce.freebsd.org/chv.cgi?CH=95016 Change 95016 by imp@imp_hammer on 2006/04/11 19:45:23 Kinky magic numbers, while kinky are somewhat unuseful. Affected files ... .. //depot/projects/arm/src/sys/boot/arm/kb920x/boot0/main.c#8 edit Differences ... ==== //depot/projects/arm/src/sys/boot/arm/kb920x/boot0/main.c#8 (text+ko) ==== @@ -31,7 +31,7 @@ main(void) { #if 0 - char *addr = (char *)0x20000000 + (1 << 20); /* Load to base + 1MB */ + char *addr = (char *)SDRAM_BASE + (1 << 20); /* Load to base + 1MB */ fn_t *fn = (fn_t *)addr; // AT91C_BASE_PIOC->PIO_SODR = AT91C_PIO_PC10; @@ -40,7 +40,7 @@ // AT91C_BASE_PIOC->PIO_CODR = AT91C_PIO_PC10; fn(); #else - int *addr = (int *)0x20000000; /* Load to base + 1MB */ + int *addr = (int *)SDRAM_BASE; /* Load to base + 1MB */ int i; while (1) {