Date: Fri, 24 Sep 1999 23:23:12 -0400 (EDT) From: Mikhail Teterin <mi@aldan.algebra.com> To: anders@fix.no Cc: ports@freebsd.org Subject: kvirc port Message-ID: <199909250323.XAA80090@rtfm.newton>
next in thread | raw e-mail | index | archive | help
Hello!
I built the port today on a 3.3 machine and found it disfunctional :(
When the kvirc first starts and attempts to create a number of
directories and seems successfull at that. It then offers to make two
symbolic links and fails, because the hardcoded ln(1) command line
contains the `-n' switch (what's it supposed to mean, anyway?). Here is
a patch for that
--- kvirc/kvi_setup.cpp.orig Sun Jan 24 18:32:29 1999
+++ kvirc/kvi_setup.cpp Fri Sep 24 17:30:20 1999
@@ -254,3 +254,3 @@
//run ln -s KVIRCDIR $HOME/kvirc
- (*lpProc) << "ln" << "-s" << "-n";
+ (*lpProc) << "ln" << "-s";
(*lpProc) << szFileToLink;
Although, in my opinion forking just to create a symlink is, mmm, lame,
but let that be the author's sin :)
Also, the CXXFLAGS are totally disregarded by the port. This is also
easy to cure:
--- kvirc/Makefile.in.orig Sun Jan 24 19:17:26 1999
+++ kvirc/Makefile.in Fri Sep 24 17:49:28 1999
@@ -136,3 +136,3 @@
INCLUDES = $(all_includes)
-CXXFLAGS = -Wall
+CXXFLAGS = @CXXFLAGS@ -Wall
LDFLAGS = $(all_libraries) $(KDE_RPATH) -s
The trouble is, after the seemingly succesful setup, it can not load the
neccessary pixmaps (all of the pixmaps listed in the kvi_frame.cpp --
not icons, but pixmaps, although they all are gif files), even though
they appear to be found, according to ktrace. This patch makes kvirc
more explicit about what exactly is missing, but I don't know Qt well
enough to understand what the reason is:
--- kvirc/kvi_frame.cpp.orig Sun Jan 24 18:32:27 1999
+++ kvirc/kvi_frame.cpp Fri Sep 24 18:23:57 1999
@@ -703,7 +703,15 @@
QPixmap pixmappa;
+ int fatal = 0;
for(int i=0;i<KVI_NUM_PIXMAPS;i++){
pixmappa=lpI->loadIcon(pixTab[i].szPixName);
- if(!pixmappa.isNull())m_lpPixmap[pixTab[i].index]=new QPixmap(pixmappa);
- else _debug_fatal(i18n("Cannot find the base pixmaps...did you forget make install?"));
+ if(!pixmappa.isNull())
+ m_lpPixmap[pixTab[i].index]=new QPixmap(pixmappa);
+ else {
+ fatal = 1;
+ KMsgBox::message(0,i18n("Unable to load icon"),
+ pixTab[i].szPixName);
+ }
}
+ if (fatal)
+ _debug_fatal(i18n("Cannot find the base pixmaps...did you forget make install?"));
pixmappa=lpI->loadIcon("kvib_op.gif");
@@ -717,5 +725,12 @@
pixmappa=lpI->loadIcon(icoTab[k].szPixName);
- if(!pixmappa.isNull())m_lpIcon[icoTab[k].index]=new QPixmap(pixmappa);
- else _debug_fatal(i18n("Cannot find the base pixmaps...did you forget make install?"));
+ if(!pixmappa.isNull())
+ m_lpIcon[icoTab[k].index]=new QPixmap(pixmappa);
+ else {
+ fatal = 1;
+ KMsgBox::message(0,i18n("Unable to load pixmap:"),
+ pixTab[k].szPixName);
+ }
}
+ if (fatal)
+ _debug_fatal(i18n("Cannot find the base pixmaps...did you forget make install?"));
_debug_leavetrace("createPixmaps");
Restarting the kvirc after this enters the silly setup again and again :(
Normally, I'd just file a PR, but this seems too obviously broken,
perhaps I'm missing something? Any clues? Yours,
-mi
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199909250323.XAA80090>