Date: Mon, 28 Oct 2002 19:23:37 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Juli Mallett <jmallett@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make Makefile job.c nonints.h str.c var.c var.h var_modify.c Message-ID: <20021029032337.GB36927@dragon.nuxi.com> In-Reply-To: <200210282333.g9SNXvvt039931@repoman.freebsd.org> References: <200210282333.g9SNXvvt039931@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 28, 2002 at 03:33:57PM -0800, Juli Mallett wrote: > jmallett 2002/10/28 15:33:57 PST > > Modified files: > usr.bin/make Makefile job.c nonints.h str.c var.c > Added files: > usr.bin/make var.h var_modify.c > Log: > Split var.c into var.c and var_modify.c and move all the modification funcs > to var_modify.c, for readability. constify some low hanging fruit (string > manipulation functions) and the upper layers appropriately. No longer use > the private strstr(3) implementation, while changing string code. Are you willing to name this varmodifiers.c and organize it simular to what OpenBSD has done? It would certainly help notice bugs fixed in their code base. Or leave things as-is to make it easier to notice bugs fixed in NetBSD? We don't need so much divergence in what once was a 100% common code base. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021029032337.GB36927>