Date: Tue, 04 Jun 2019 00:07:54 +0000 From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 147881] [zfs] [patch] ZFS "sharenfs" doesn't allow different "exports" options for different hosts Message-ID: <bug-147881-3630-tEp8ZLXPVN@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-147881-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-147881-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D147881 --- Comment #16 from Rick Macklem <rmacklem@FreeBSD.org> --- Personally, I think Quentin Rameau's patch is all you need. I don't think embedded comments in the sharenfs property are needed and it just makes the patch much more involved. The one slightly scary thing about it is that "; ;" is allowed and results in the file system being exported read/write to the world, because it will generate a line with just the mountpoint in it. (I never use ZFS, so I don't know if a blank sharenfs property is allowed and results in the same thing?) It might be safer to not allow that case? One other change would be to take the "const" off the argument for translate_opts() and don't have it strlcpy() the shareopts, since they have already be copied by the caller with Quentin's patch. I don't recommend changing the exports(5) syntax for two reasons: 1- Any change must be 100% backwards compatible or it is a POLA violation and can't go in FreeBSD. (ie. Any exports file that worked before must still work and provide the same semantics.) 2 - Parsing of exports file(s) is done by a function called get_exportlist_one() in src/usr.sbin/mountd/mountd.c and, if you look at it, you will find the code convoluted and difficult to modify without breaking it. I'm not a ZFS guy, so I can't help w.r.t. getting this in FreeBSD. I'd suggest you post on a FreeBSD mailing list about this and hope that someone on the ZFS side is interested in getting the patch in. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-147881-3630-tEp8ZLXPVN>