Date: Thu, 16 Jul 2015 09:34:00 +0000 From: "kib (Konstantin Belousov)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Accepted] D3094: Fix KSTACK_PAGES issue Message-ID: <974b08ce24f5bf9f8cb1965b19c1907f@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-iyfes6yosmvf4z7iwnvz-req@FreeBSD.org> References: <differential-rev-PHID-DREV-iyfes6yosmvf4z7iwnvz-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
kib accepted this revision. kib added a reviewer: kib. kib added a comment. This revision has a positive review. I am fine with the last patch, which adds missing include. Note that it uncovers more serious issues. E.g., the quick look at the amd64/amd64/stack_machdep.c clearly indicates that the use of KSTACK_PAGES there is bogus, probably curthread->td_kstack_pages is the right thing to use, but it is still not quite correct as well. In fact, the if() should check whether the f_frame is inside the [curthread->td_kstack; curthread->td_kstack + PAGE_SIZE * curthread->td_kstack_pages). REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D3094 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: wma_semihalf.com, emaste, zbb, andrew, kib Cc: kib, imp, andrew, freebsd-arm-list, emaste
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?974b08ce24f5bf9f8cb1965b19c1907f>