From owner-svn-src-stable@FreeBSD.ORG Mon Oct 13 18:32:52 2008 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CF85106568B for ; Mon, 13 Oct 2008 18:32:52 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186]) by mx1.freebsd.org (Postfix) with ESMTP id 172218FC2C for ; Mon, 13 Oct 2008 18:32:51 +0000 (UTC) (envelope-from max@love2party.net) Received: from vampire.homelinux.org (dslb-088-066-027-214.pools.arcor-ip.net [88.66.27.214]) by mrelayeu.kundenserver.de (node=mrelayeu4) with ESMTP (Nemesis) id 0ML21M-1KpS1f2qW3-00081t; Mon, 13 Oct 2008 20:20:16 +0200 Received: (qmail 86778 invoked from network); 13 Oct 2008 18:20:14 -0000 Received: from fbsd8.laiers.local (192.168.4.151) by router.laiers.local with SMTP; 13 Oct 2008 18:20:14 -0000 From: Max Laier Organization: FreeBSD To: "Christian S.J. Peron" Date: Mon, 13 Oct 2008 20:20:12 +0200 User-Agent: KMail/1.10.1 (FreeBSD/8.0-CURRENT; KDE/4.1.1; i386; ; ) References: <200810122347.m9CNl63T058515@svn.freebsd.org> In-Reply-To: <200810122347.m9CNl63T058515@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810132020.13577.max@love2party.net> X-Provags-ID: V01U2FsdGVkX1+aFebAscFX8k6gajQJh+boVTJlU07b0ZGEDRI ZzejOGsRJ9xWKyI9KgtbBfQPYolxBYclJcqMa5tWVvWD8MxhIQ 1stV6nUel0rUynkujE9kA== Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-6@freebsd.org Subject: Re: svn commit: r183813 - in stable/6/sys: . netinet/libalias X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Oct 2008 18:32:52 -0000 On Monday 13 October 2008 01:47:06 Christian S.J. Peron wrote: > Author: csjp > Date: Sun Oct 12 23:47:06 2008 > New Revision: 183813 > URL: http://svn.freebsd.org/changeset/base/183813 > > Log: > MFC revision 183744 > > Improve entropy in source port generation for libalias consumers. > > Approved by: re (kib) Thanks! > > Modified: > stable/6/sys/ (props changed) > stable/6/sys/netinet/libalias/alias_db.c > > Modified: stable/6/sys/netinet/libalias/alias_db.c > =========================================================================== >=== --- stable/6/sys/netinet/libalias/alias_db.c Sun Oct 12 23:19:23 > 2008 (r183812) +++ stable/6/sys/netinet/libalias/alias_db.c Sun Oct 12 > 23:47:06 2008 (r183813) @@ -603,7 +603,7 @@ GetNewPort(struct libalias *la, > struct a > port_sys = ntohs(port_net); > } else { > /* First trial and all subsequent are random. */ > - port_sys = random() & ALIAS_PORT_MASK; > + port_sys = arc4random() & ALIAS_PORT_MASK; > port_sys += ALIAS_PORT_BASE; > port_net = htons(port_sys); > } > @@ -654,7 +654,7 @@ GetNewPort(struct libalias *la, struct a > } > #endif > } > - port_sys = random() & ALIAS_PORT_MASK; > + port_sys = arc4random() & ALIAS_PORT_MASK; > port_sys += ALIAS_PORT_BASE; > port_net = htons(port_sys); > } > @@ -767,9 +767,9 @@ FindNewPortGroup(struct libalias *la, > > /* First trial and all subsequent are random. */ > if (align == FIND_EVEN_ALIAS_BASE) > - port_sys = random() & ALIAS_PORT_MASK_EVEN; > + port_sys = arc4random() & ALIAS_PORT_MASK_EVEN; > else > - port_sys = random() & ALIAS_PORT_MASK; > + port_sys = arc4random() & ALIAS_PORT_MASK; > > port_sys += ALIAS_PORT_BASE; > } > @@ -791,9 +791,9 @@ FindNewPortGroup(struct libalias *la, > > /* Find a new base to try */ > if (align == FIND_EVEN_ALIAS_BASE) > - port_sys = random() & ALIAS_PORT_MASK_EVEN; > + port_sys = arc4random() & ALIAS_PORT_MASK_EVEN; > else > - port_sys = random() & ALIAS_PORT_MASK; > + port_sys = arc4random() & ALIAS_PORT_MASK; > > port_sys += ALIAS_PORT_BASE; > } -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News