From owner-svn-src-head@freebsd.org Tue Aug 16 18:16:31 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A4F1BBCA1E for ; Tue, 16 Aug 2016 18:16:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3AB3F15DF for ; Tue, 16 Aug 2016 18:16:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x242.google.com with SMTP id f6so6039249ith.2 for ; Tue, 16 Aug 2016 11:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=n0TQNVExKJPEOBzjY0Vm3z3vsr6k5lC+iO/PH3N5x+0=; b=VQK2G3HCuUERdAk9YEVt7IiMuKAyaRAP65vSCYDtR5NeztpZjudiJBXrkN8NY1vIGU VMuhk5B8dSOpT1gHiD/g3zkqs2S3MSTryU20lEyYfDxX7gCbiMhpwMazMyVaKgh1x0NZ 6OnAmFqaEsPAf7BEWvCQ4RSQtp9Ama+H5qaNRAt8Sp3/CHdTDAg3keOBapF8FSlSGabK n+O7CNEPMPV/Dbt6pGWwUqD2eDEEbTJapFwPeNrid0RXgpO37n43EwnQVFlhejJd0NWy DBDiysM0KVxGLR3kNuxsJqkW3eZL9x7Z1hJ9Ivlei/JRijiIhiB2dZsI9+dpYiHAONg9 OTIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=n0TQNVExKJPEOBzjY0Vm3z3vsr6k5lC+iO/PH3N5x+0=; b=OUG4+EtXltx6srSmIQVAQEXHbVkzQzdnYj+h720S60hJrVjQ1NMrIMObZhlZqNgtRY YM3VP1tO8tTWui57uD5xTGyaUQ+k9DQ1bEN8/h5b3/i87/leH9SzIMj0xRwjahx9KDB4 HfnVdMVx72C3P7rqA/9nsTxPUtJ6nn60inOoXLGgzYbThS6LC+VT/E9vlW6FMXtO1vDH kmw0dxiY/5/0SLCCACIUXN9uEomvgtnKBTuD8WrttIIXqy2RjFNN5b99cPMA9R4cTCBW eJbPSFmXL6gxHuIslv45g4T07i8U15l14DSrI5sWocV1pEtLZ9/pSk3lf3rVWxldPCf1 QoAQ== X-Gm-Message-State: AEkoouswGFbcmGwvlHuUFYgxSaPASuZg5BCLJpUVw2dIUlijb8WS8dMR0lS9MkJ1kcmMcu52Et9Tq/57428g3A== X-Received: by 10.36.84.147 with SMTP id t141mr11154023ita.14.1471371390529; Tue, 16 Aug 2016 11:16:30 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.36.96.202 with HTTP; Tue, 16 Aug 2016 11:16:30 -0700 (PDT) X-Originating-IP: [69.53.245.200] In-Reply-To: References: <201608161423.u7GENZJi021956@repo.freebsd.org> From: Warner Losh Date: Tue, 16 Aug 2016 12:16:30 -0600 X-Google-Sender-Auth: K_zkFLPTxYAop3JYedALsXphzsQ Message-ID: Subject: Re: svn commit: r304221 - head/sys/boot/efi/boot1 To: Ed Schouten Cc: Emmanuel Vadot , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 18:16:31 -0000 On Tue, Aug 16, 2016 at 8:57 AM, Ed Schouten wrote: > Hi Emmanuel, > > 2016-08-16 16:23 GMT+02:00 Emmanuel Vadot : >> Author: manu >> Date: Tue Aug 16 14:23:35 2016 >> New Revision: 304221 >> URL: https://svnweb.freebsd.org/changeset/base/304221 >> >> Log: >> Use %ju modifier for u_int64_t and %jd modifier for off_t. >> off_t is long long on arm32 and long on amd64 > > I think both of these should be solved differently: > > - For uint64_t, you can use 's PRIu64 in the formatting > string. In kernel space, I suspect you need to use something like > . cast it to intmax_t and use %jd. We've shunned PRIu64 in the tree. It's existing practice, but I'm sure bruce will voice mild distaste. > - For off_t, it's all right to print it with %jd, but then be sure to > also add a cast to the argument itself. It may not necessarily be > equal to an intmax_t. The cast is important. Warner