Date: Thu, 14 Jul 2005 18:37:02 +0300 From: Niki Denev <nike_d@cytexbg.com> To: freebsd-current@freebsd.org Subject: Re: add a few informative printfs to if_bridge.c? Message-ID: <200507141837.02609.nike_d@cytexbg.com> In-Reply-To: <20050713210811.GA60866@heff.fud.org.nz> References: <200507121026.16664.nike_d@cytexbg.com> <20050713210811.GA60866@heff.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 14 July 2005 00:08, Andrew Thompson wrote: > On Tue, Jul 12, 2005 at 10:26:16AM +0300, Niki Denev wrote: > > Hello all, > > > > So, i have a proposition to add some informative printfs to if_bridge > > code, because returning "Invalid argument" is not so self explanatory, > > especially in the wrong MTU case. I think that most of the returns in > > bridge_ioctl_add(), could benefit from additional printf with more > > information. > > What do you think? > > Ive added a message for the incorrect MTU case and also relaxed the > requirements a little. The bridge will take the MTU of the first member > interface rather than being hardcoded at 1500, all members are still > required to have the exact same MTU. > > > cheers, > > Andrew Thanks! --niki
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507141837.02609.nike_d>