From owner-freebsd-current@FreeBSD.ORG Wed Apr 9 08:42:12 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3320D37B40D for ; Wed, 9 Apr 2003 08:42:12 -0700 (PDT) Received: from mail1.arcor-ip.de (mail1.arcor-ip.de [145.253.2.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37C0F43F85 for ; Wed, 9 Apr 2003 08:42:11 -0700 (PDT) (envelope-from Friedemann.Becker@student.uni-tuebingen.de) Received: from chasey (213.23.40.87) by mail1.arcor-ip.de (5.5.034) id 3E1E8763005B20C5; Wed, 9 Apr 2003 17:41:48 +0200 Date: Wed, 9 Apr 2003 17:41:47 +0200 (=?ISO-8859-1?Q?Westeurop=E4ische_Sommerzeit?=) From: Friedemann Becker To: Poul-Henning Kamp In-Reply-To: <30856.1049874312@critter.freebsd.dk> Message-ID: References: <30856.1049874312@critter.freebsd.dk> X-X-Sender: zxmxy33@mailserv02.uni-tuebingen.de MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-current@freebsd.org cc: Andre Guibert de Bruet Subject: Re: systat -v on -CURRENT X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Friedemann.Becker@student.uni-tuebingen.de List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Apr 2003 15:42:12 -0000 hmmm..... I don't know.... :) devstat_compute_etime(struct bintime *cur_time, struct bintime *prev_time) is responsable for calculating the difference between cur_time and prev_time, but knows nothing about the correctness of the result. someone could use the function for calculating negative differences or something (you can never know.... ;-) so i think, it would be better in vmstat.c (usr.bin/systat), as there is already a check, if busytime = devstat_compute_etime(...) is bigger than 100%, so <0 should be checked right there too, i think look at the patche I posted to -hackers.... Friedemann On Wed, 9 Apr 2003, Poul-Henning Kamp wrote: > In message <20030409023754.P92580@alpha.siliconlandmark.com>, Andre Guibert de > Bruet writes: > > > >I just spotted this today... > > > >Disks ad4 ad6 acd0 ofod intrn > >KB/t 0.00 0.00 0.00 %slo-z 114272 buf > >tps 0 0 0 tfree 13 dirtybuf > >MB/s 0.00 0.00 0.00 70224 desiredvnodes > >% busy -0. -0. 0 1046 numvnodes > > > Yeah, I saw that too. It's a rounding error. If you dive into it you > will see that the number is incredibly close to zero. > > We should probably catch that in libdevstat. > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. >