Date: Tue, 19 Feb 2008 21:01:16 +0100 From: Marius Strobl <marius@alchemy.franken.de> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/cdrtools-devel Makefile pkg-plist ports/sysutils/cdrtools-devel/files patch-libsiconv-sic_nls.c Message-ID: <20080219200116.GA37953@alchemy.franken.de> In-Reply-To: <47BA016C.9080302@FreeBSD.org> References: <200802182148.m1ILmv96094438@repoman.freebsd.org> <47BA016C.9080302@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 18, 2008 at 02:06:36PM -0800, Doug Barton wrote: > Marius Strobl wrote: > >marius 2008-02-18 21:48:57 UTC > > > > FreeBSD ports repository (src committer) > > > > Modified files: > > sysutils/cdrtools-devel Makefile pkg-plist > > Added files: > > sysutils/cdrtools-devel/files patch-libsiconv-sic_nls.c > > Log: > > Fix `mkisofs -input-charset`: > > - The configure script adds dependencies on libiconv and libintl when > > found so set USE_GETTEXT and USE_ICONV accordingly. If these libraries > > are not yet installed, these dependencies can be turned off by defining > > WITHOUT_NLS. There's no easy way to force these dependencies off as > > the configure script doesn't offer such a knob and modifying its tests > > is not allowed. > > I'm confused, why is modifying the tests not allowed? In order to not need to remove the IS_SCHILY_XCONFIG macro, which makes our cdrtools port provide an inofficial version that is not supported by the author, which is something I'd like to avoid. /* * Begin restricted code for quality assurance. * * Warning: you are not allowed to include the #define below if you are not * using the Schily makefile system or if you modified the autoconfiguration * tests. * * If you only added other tests you are allowed to keep this #define. * * This restiction is introduced because this way, I hope that people * contribute to the project instead of creating branches. */ #define IS_SCHILY_XCONFIG /* * End restricted code for quality assurance. */ Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080219200116.GA37953>