Date: Fri, 30 Jul 1999 18:53:33 -0700 From: Mike Smith <mike@smith.net.au> To: Mike Smith <msmith@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfs nfs_vnops.c Message-ID: <199907310153.SAA02537@dingo.cdrom.com> In-Reply-To: Your message of "Fri, 30 Jul 1999 18:52:00 PDT." <199907310152.SAA89352@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
BTW. these changes are applicable to 3.1 and 2.2.8 as well, if people are interested in seeing them brought back. > msmith 1999/07/30 18:52:00 PDT > > Modified files: > sys/nfs nfs_vnops.c > Log: > As described by the submitter: > > I did some tcpdumping the other day and noticed that GETATTR calls > were frequently followed by an ACCESS call to the same file. The > attached patch changes nfs_getattr to fill the access cache as a side > effect. This is accomplished by calling ACCESS rather than > GETATTR. This implies a modest overhead of 4 bytes in the request and > 8 bytes in the response compared to doing a vanilla GETATTR. > ... > [The patch comprises two parts] The first > is the "real" patch, the second counts misses and hits rather than > fills and hits. The difference is subtle but important because both > nfs_getattr and nfs_access now fill the cache. It also changes the > default value of nfsaccess_cache_timeout to better match the attribute > cache. IMHO, file timestamps change much more frequently than > protection bits. > > Submitted by: Bjoern Groenvall <bg@sics.se> > Reviewed by: dillon (partially) > > Revision Changes Path > 1.138 +55 -34 src/sys/nfs/nfs_vnops.c > > > -- \\ The mind's the standard \\ Mike Smith \\ of the man. \\ msmith@freebsd.org \\ -- Joseph Merrick \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907310153.SAA02537>