From owner-svn-src-stable-9@FreeBSD.ORG  Sat Sep 28 15:29:38 2013
Return-Path: <owner-svn-src-stable-9@FreeBSD.ORG>
Delivered-To: svn-src-stable-9@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 57756DB6;
 Sat, 28 Sep 2013 15:29:38 +0000 (UTC)
 (envelope-from Andre.Albsmeier@siemens.com)
Received: from goliath.siemens.de (goliath.siemens.de [192.35.17.28])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id DC71121AE;
 Sat, 28 Sep 2013 15:29:37 +0000 (UTC)
Received: from mail1.siemens.de (localhost [127.0.0.1])
 by goliath.siemens.de (8.13.6/8.13.6) with ESMTP id r8SFRGoU004566;
 Sat, 28 Sep 2013 17:27:16 +0200
Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.40.130])
 by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id r8SFRF0k025066;
 Sat, 28 Sep 2013 17:27:16 +0200
Received: (from localhost)
 by curry.mchp.siemens.de (8.14.7/8.14.7) id r8SFRFYS074864;
Date: Sat, 28 Sep 2013 17:27:15 +0200
From: Andre Albsmeier <Andre.Albsmeier@siemens.com>
To: Scott Long <scottl@freebsd.org>
Subject: Re: svn commit: r252063 - stable/9/sys/geom/mirror
Message-ID: <20130928152715.GA4571@bali>
References: <201306211736.r5LHaYPN070052@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201306211736.r5LHaYPN070052@svn.freebsd.org>
X-Echelon: <censored>
X-Advice: Drop that crappy M$-Outlook, I'm tired of your viruses!
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: "svn-src-stable@freebsd.org" <svn-src-stable@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-stable-9@freebsd.org" <svn-src-stable-9@freebsd.org>
X-BeenThere: svn-src-stable-9@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for only the 9-stable src tree
 <svn-src-stable-9.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-stable-9>, 
 <mailto:svn-src-stable-9-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-9>
List-Post: <mailto:svn-src-stable-9@freebsd.org>
List-Help: <mailto:svn-src-stable-9-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable-9>, 
 <mailto:svn-src-stable-9-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Sep 2013 15:29:38 -0000

On Fri, 21-Jun-2013 at 19:36:34 +0200, Scott Long wrote:
> Author: scottl
> Date: Fri Jun 21 17:36:33 2013
> New Revision: 252063
> URL: http://svnweb.freebsd.org/changeset/base/252063
> 
> Log:
>   MFC r252010, r252011:
>   
>   Mark geom_mirror as capable of unmapped i/o
>   
>   Obtained from:	Netflix
> ...
> +			/* A provider underneath us doesn't support unmapped */
> +			if ((dp->flags & G_PF_ACCEPT_UNMAPPED) == 0) {
> +				G_MIRROR_DEBUG(0, "cancelling unmapped "
> +				    "because of %s\n", dp->name);
> +				pp->flags &= ~G_PF_ACCEPT_UNMAPPED;
> +			}

Is the \n intended here? It produces blank lines in dmesg:
  
...
ada1: <SAMSUNG HD321KJ CP100-11> ATA-8 SATA 2.x device
ada1: 150.000MB/s transfers (SATA 1.x, UDMA5, PIO 8192bytes)
ada1: 305245MB (625142448 512 byte sectors: 16H 63S/T 16383C)
Timecounter "TSC-low" frequency 1099900874 Hz quality 800
GEOM_MIRROR: cancelling unmapped because of ada1
  
GEOM_MIRROR: cancelling unmapped because of ada0
  
GEOM_MIRROR: Device mirror/m0 launched (2/2).
uhub0: 2 ports with 2 removable, self powered
uhub1: 2 ports with 2 removable, self powered
uhub2: 2 ports with 2 removable, self powered
uhub3: 2 ports with 2 removable, self powered
...

        -Andre