Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Mar 2017 21:22:46 +1100 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Ngie Cooper <ngie@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r316081 - head/lib/libcam
Message-ID:  <20170328205205.O1920@besplex.bde.org>
In-Reply-To: <201703280824.v2S8OGTb066055@repo.freebsd.org>
References:  <201703280824.v2S8OGTb066055@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 28 Mar 2017, Ngie Cooper wrote:

> Log:
>  Use `sizeof(cam_errbuf)` instead of `CAM_ERRBUF_SIZE` in snprintf calls
>
>  Reindent snprintf calls' arguments to match style(9) guidelines with
>  respect to indentation.

Unfortunately, cam is is supposed to not match style(9) guidelines for
indentation.  It has its own style for many things, and used to follow
this very consistently.  Its style for continuation indentation is the
same as gnu style (-lp).

The following of -lp seems to have been perfect for multi-line
snprintf()s in camlib.c.  This gave 56 lines perfectly not matching
style(9), or about 1/4 of the non-matches.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170328205205.O1920>