From owner-svn-src-all@freebsd.org Tue Jan 29 16:35:34 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 850A114C2EA0; Tue, 29 Jan 2019 16:35:34 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F2CCB8E359; Tue, 29 Jan 2019 16:35:33 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x52b.google.com with SMTP id z10so8957294pgp.7; Tue, 29 Jan 2019 08:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=va/A+/JvGrHs7Kh2Jw+9KqvPvvVWrAjy4vh12s3pA5c=; b=b1I5qrRNnrESMFGcXpmzTvXDMdcZy2ImwvmER/P9CTrSy94Uiu2NKsj11QqrVJlbPu FVXuuLQMN5cVpJWPzcnaPzuieXC0Rmj8VZVAOOBeHfGe4E+ndzDim8BaAgN0RvjwY/5Q 4FQJMQb5QUzDSDUEF2J+OciTUXVpPRykWtvdu0Wv5Y1XjX/pe+3zMSBctQNAnu0F/Th8 BWeNy4/IbiJI3lKYEsxw/LmAinekx+xq/TTVpi9nUHTAzL9NR2KRfKNFtX+MOYZfSo4v Bb5F3SldDo7dJTbczmwprP7yg5qVV7OTxxLDwoaEPbBQjl9+oNJvjAlkAg0JoInHXVXl 577Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=va/A+/JvGrHs7Kh2Jw+9KqvPvvVWrAjy4vh12s3pA5c=; b=e4SKWEoPJTrtoplAOETlCOTSPDHSEELNhAQLZALFFCHUk245VAB2DtKCQXriWtRpGl nTHWqNwOUrC+aG23WG2AEELc2x+GDCuqcHF01Ymq28vA5f94FoOvVcP/cc3mMcR0DBX7 8X5DXRPiKGJrMxE+2XIIl2W/G0b0bNtl+jc85xvaAoeji6ulRg+hJytHP835ji2mVxUB YubweFEGXXmgCf7t+6rk4cS/YSTC+ZeqTrvDyWl1gHsocez5V7h4C2wNE1UAabPrZc8F l2OnSRMdMnPNaRi0XpL/Wu7qR/PqXxRZOXuRqnyZnGDJZM7Ct9UE51zkX22+zezrfmP3 t1fg== X-Gm-Message-State: AJcUukcdIbHZJls9EBZ8REBJadLWMWQBxUmyOoH4PVRh0AQSADh5jRVL YKiSGtjPkb6O5XVHw0be3Oi1RYuy X-Google-Smtp-Source: ALg8bN4jbZheOL7YSMmibtOvr3XFnr/7c5Tohx94CyhZ7A/fOWyxdnJsoG4Stk1djyjZCieUb3cqQQ== X-Received: by 2002:a63:1d59:: with SMTP id d25mr24702061pgm.180.1548779732733; Tue, 29 Jan 2019 08:35:32 -0800 (PST) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id m3sm70950053pff.173.2019.01.29.08.35.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 08:35:31 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r343543 - head/sbin/bectl/tests From: Enji Cooper X-Mailer: iPhone Mail (16C104) In-Reply-To: <201901290431.x0T4VrZm006702@pdx.rh.CN85.dnsmgr.net> Date: Tue, 29 Jan 2019 08:35:31 -0800 Cc: Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <82187F03-C50D-4430-9764-ABA6E28125E9@gmail.com> References: <201901290431.x0T4VrZm006702@pdx.rh.CN85.dnsmgr.net> To: rgrimes@freebsd.org X-Rspamd-Queue-Id: F2CCB8E359 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.971,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 16:35:34 -0000 On Jan 28, 2019, at 20:31, Rodney W. Grimes = wrote: >>> On Mon, Jan 28, 2019 at 10:09 PM Kyle Evans wrote: >>>=20 >>> Author: kevans >>> Date: Tue Jan 29 04:08:49 2019 >>> New Revision: 343543 >>> URL: https://svnweb.freebsd.org/changeset/base/343543 >>>=20 >>> Log: >>> bectl(8) test: Force destroy the zpool in cleanup >>>=20 >>> This is a wild guess as to why bectl tests failed once upon a time in C= I, >>> given no apparent way to see a transcript of cleanup routines with Kyua= . The >>> bectl tests construct a new, clean zpool for every test. The failure >>> indicated was because of a mount that was leftover from a previous test= , but >>> the previous test had succeeded so it's not clear how the mount remaine= d >>> leftover unless the `zpool get health ${pool}` had somehow failed. >>>=20 >>=20 >> I left out: the tests are supposed to be constructed to clean up any >> mounts that were left over in the course of the test, hence the >> assumption that the failure lies in the cleanup. Hi Rod, > =46rom my experience as a hardware test engineer the test > setup was required to make sure any of those assumptions > are valid. Meaning that the test would have to validate > that no left over cruft was going to interfere with the > test about to be run. >=20 > Ie, you should probably do a force destroy of the pool > *before* the test too. While this approach makes sense and is valid, it would leave open/orphaned r= esources after each test run (in this case a single zpool). It=E2=80=99s bes= t to fix the underlying issue with how the test formulates, sets up, and tea= rs down the zpool. Cheers, -Enji=