From owner-freebsd-net@FreeBSD.ORG  Sun Aug 24 16:22:55 2008
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 59D8C106567A
	for <net@FreeBSD.org>; Sun, 24 Aug 2008 16:22:55 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id E9D7C8FC2C
	for <net@FreeBSD.org>; Sun, 24 Aug 2008 16:22:54 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m7OGL9af023425;
	Sun, 24 Aug 2008 10:21:10 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Sun, 24 Aug 2008 10:21:44 -0600 (MDT)
Message-Id: <20080824.102144.-705600373.imp@bsdimp.com>
To: rik@inse.ru
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <48B14019.80901@localhost.inse.ru>
References: <20080824.012750.-1186539247.imp@bsdimp.com>
	<48B14019.80901@localhost.inse.ru>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: net@FreeBSD.org
Subject: Re: Code review request
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Aug 2008 16:22:55 -0000

In message: <48B14019.80901@localhost.inse.ru>
            Roman Kurakin <rik@inse.ru> writes:
: M. Warner Losh wrote:
: > I've been shepherding this patch in my p4 tree for a long time.  It
: > removes the obsolete support for other systems in if_spppsubr.c.  Is
: > there a reason I shouldn't commit this?
: >   
: It was there to ease the keeping code in sync with other systems.
: Please ask Joerg Wunsch before removal.

Yea, I knew that history.  But there's been a lot of hacking on this
file, and the ifdef's are for other systems that were contemporaneous
with FreeBSD 3.0, but nothing newer.  Plus the FreeBSDisms that are
newer haven't been ifdef'd.

Warner