Date: Wed, 24 Sep 2008 17:00:11 GMT From: "Jeremy Messenger" <mezz7@cox.net> To: gnome@FreeBSD.org Subject: Re: ports/127297: Redefinition warnings in print/freetype2 Message-ID: <200809241700.m8OH0BIM036351@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/127297; it has been noted by GNATS.
From: "Jeremy Messenger" <mezz7@cox.net>
To: bug-followup@freebsd.org, koitsu@freebsd.org
Cc:
Subject: Re: ports/127297: Redefinition warnings in print/freetype2
Date: Wed, 24 Sep 2008 11:58:26 -0500
> The pre-patch section comments out #define
> TT_CONFIG_OPTION_BYTECODE_INTERPRETER in
> include/freetype/config/ftoption.h (when WITHOUT_TTF_BYTECODE_ENABLED is
> not defined by the user), but then earlier in the Makefile, it
> re-enables it:
I am not seeing any bug. When the WITHOUT_TTF_BYTECODE_ENABLED is not
defined then the TT_CONFIG_OPTION_BYTECODE_INTERPRETER will be enable,
which is a correct behavior. Unless I am blind?
--------------------------------------------------------
# pwd
/usr/ports/print/freetype2
# make extract
# grep TT_CONFIG_OPTION_BYTECODE_INTERPRETER
work/freetype-2.3.7/include/freetype/config/ftoption.h
/* Define TT_CONFIG_OPTION_BYTECODE_INTERPRETER if you want to compile
*/
/* #define TT_CONFIG_OPTION_BYTECODE_INTERPRETER */ <-- disable
/* define TT_CONFIG_OPTION_BYTECODE_INTERPRETER; with other words,
*/
/* either define TT_CONFIG_OPTION_BYTECODE_INTERPRETER or
*/
#ifdef TT_CONFIG_OPTION_BYTECODE_INTERPRETER
# make patch
# grep TT_CONFIG_OPTION_BYTECODE_INTERPRETER
work/freetype-2.3.7/include/freetype/config/ftoption.h
/* Define TT_CONFIG_OPTION_BYTECODE_INTERPRETER if you want to compile
*/
#define TT_CONFIG_OPTION_BYTECODE_INTERPRETER <-- enable
/* define TT_CONFIG_OPTION_BYTECODE_INTERPRETER; with other words,
*/
/* either define TT_CONFIG_OPTION_BYTECODE_INTERPRETER or
*/
#ifdef TT_CONFIG_OPTION_BYTECODE_INTERPRETER
--------------------------------------------------------
There is no problem. As for the redefine warning, I think it's harmless
since it's still enable with no change as it's merely enable again.
Cheers,
Mezz
--
mezz7@cox.net - mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809241700.m8OH0BIM036351>