From owner-svn-src-head@FreeBSD.ORG  Wed Oct 13 21:03:30 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id F06861065672;
	Wed, 13 Oct 2010 21:03:28 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Rui Paulo <rpaulo@freebsd.org>
Date: Wed, 13 Oct 2010 17:03:03 -0400
User-Agent: KMail/1.6.2
References: <201010131439.o9DEdssc090571@svn.freebsd.org>
	<201010131546.10130.jkim@FreeBSD.org>
	<F670176F-BA62-44ED-9CC5-06C36A191258@freebsd.org>
In-Reply-To: <F670176F-BA62-44ED-9CC5-06C36A191258@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201010131703.21145.jkim@FreeBSD.org>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r213779 - head/sys/dev/sound/pci
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Oct 2010 21:03:30 -0000

On Wednesday 13 October 2010 04:30 pm, you wrote:
> I read the PR and the mailing list posts, but I don't see what
> problem does "case SPICDS_TYPE_AK4381 || SPICDS_TYPE_AK4396:" fix.

A similar bug for right channel was fixed by netchild@ in r188480:

http://svn.freebsd.org/viewvc/base/head/sys/dev/sound/pci/spicds.c?view=log

but he missed the left channel, which caused volume differences 
between the two channels.

"In FreeBSD 7.2 it worked just like a charm but after upgrading to 8.0
the left stereo channel is only half as loud as the right one. It can 
be reproduced with either speakers and headphones. I tracked it down 
to a change in revision 188480 of spicds.c, the change "fix: stupid 
bug with volume control for AK4396" breaks volume control for me.

http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010553.html

Carl Johan Gustavsson submitted a correct patch:

http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010558.html

ariff@ said he would take it but I guess he never did:

http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010575.html

Jung-uk Kim