From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Oct 10 15:40:04 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F2E71106564A for ; Mon, 10 Oct 2011 15:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CAD8A8FC1C for ; Mon, 10 Oct 2011 15:40:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p9AFe3Am087010 for ; Mon, 10 Oct 2011 15:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p9AFe3lD087009; Mon, 10 Oct 2011 15:40:03 GMT (envelope-from gnats) Resent-Date: Mon, 10 Oct 2011 15:40:03 GMT Resent-Message-Id: <201110101540.p9AFe3lD087009@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Nali Toja Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6F5081065677 for ; Mon, 10 Oct 2011 15:38:16 +0000 (UTC) (envelope-from nalitoja@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3D2E28FC15 for ; Mon, 10 Oct 2011 15:38:15 +0000 (UTC) Received: by iaby12 with SMTP id y12so3330253iab.13 for ; Mon, 10 Oct 2011 08:38:15 -0700 (PDT) Received: by 10.231.82.12 with SMTP id z12mr8737512ibk.36.1318261095655; Mon, 10 Oct 2011 08:38:15 -0700 (PDT) Received: from nil (exit-01c.noisetor.net. [173.254.216.68]) by mx.google.com with ESMTPS id bu33sm16387746ibb.11.2011.10.10.08.38.10 (version=SSLv3 cipher=OTHER); Mon, 10 Oct 2011 08:38:14 -0700 (PDT) Message-Id: <86ehykx3vs.fsf@gmail.com> Date: Mon, 10 Oct 2011 15:36:48 +0000 From: Nali Toja To: FreeBSD-gnats-submit@FreeBSD.org Cc: Subject: ports/161463: [patch] Mk/bsd.gecko.mk: remove some vendor optimization for WITHOUT_OPTIMIZED_CFLAGS X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2011 15:40:04 -0000 >Number: 161463 >Category: ports >Synopsis: [patch] Mk/bsd.gecko.mk: remove some vendor optimization for WITHOUT_OPTIMIZED_CFLAGS >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Oct 10 15:40:03 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Nali Toja >Release: FreeBSD 10.0-CURRENT amd64 >Organization: >Environment: >Description: Since bug#680277 optimized builds always add -fomit-frame-pointer after user CFLAGS which makes it harder to capture callchain information using pmcstat(8), dtrace(1) or gdb(1). And since --enable-optimize is enabled by default there is no way around short of defining WITH_DEBUG that may have undesirable effects, e.g. CFLAGS := ${CFLAGS:N-O*:N-fno-strict*} ${DEBUG_FLAGS} # from bsd.port.mk MOZ_DEBUG_ENABLE_DEFS="-DDEBUG -D_DEBUG -DTRACING" # from configure.in >How-To-Repeat: $ cd www/firefox; make install STRIP= $ firefox & $ pmcstat -t firefox -P instructions -T and look at the CALLERS column for libxul.so >Fix: --- optimize.diff begins here --- Index: Mk/bsd.gecko.mk =================================================================== RCS file: /a/.csup/ports/Mk/bsd.gecko.mk,v retrieving revision 1.42 diff -u -p -r1.42 bsd.gecko.mk --- Mk/bsd.gecko.mk 28 Sep 2011 03:14:22 -0000 1.42 +++ Mk/bsd.gecko.mk 10 Oct 2011 14:20:22 -0000 @@ -663,11 +663,12 @@ MOZ_MK_OPTIONS+= XP_UNIX=1 \ PERL=${PERL} .if defined(WITH_OPTIMIZED_CFLAGS) +MOZ_OPTIONS+= --enable-optimize=${WITH_OPTIMIZE} CFLAGS:= ${CFLAGS} -O2 -fno-strict-aliasing ${EXTRA_CFLAGS} WITH_OPTIMIZE?= -O2 .else +MOZ_OPTIONS+= --disable-optimize CFLAGS:= ${CFLAGS} ${EXTRA_CFLAGS} -WITH_OPTIMIZE?= .endif .if defined(WITH_SMB) @@ -687,8 +688,7 @@ MOZ_OPTIONS+= --enable-strip --enable-in MOZ_OPTIONS+= --enable-debug WITH_LOGGING= yes .else -MOZ_OPTIONS+= --disable-debug \ - --enable-optimize=${WITH_OPTIMIZE} +MOZ_OPTIONS+= --disable-debug .endif .if defined(WITH_JAVA) && defined(_WITH_JAVA) --- optimize.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: