From owner-cvs-all@FreeBSD.ORG Sun May 6 16:08:44 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0560B16A400; Sun, 6 May 2007 16:08:44 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id CE16B13C45D; Sun, 6 May 2007 16:08:43 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 4B44946F4E; Sun, 6 May 2007 12:08:43 -0400 (EDT) Date: Sun, 6 May 2007 17:08:43 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Andre Oppermann In-Reply-To: <463DF9D6.4000004@freebsd.org> Message-ID: <20070506170802.L24765@fledge.watson.org> References: <200705061516.l46FG6we030349@repoman.freebsd.org> <20070506162919.G24765@fledge.watson.org> <463DF9D6.4000004@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 May 2007 16:08:44 -0000 On Sun, 6 May 2007, Andre Oppermann wrote: > Robert Watson wrote: >> >> On Sun, 6 May 2007, Andre Oppermann wrote: >> >>> andre 2007-05-06 15:16:06 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/netinet tcp_input.c >>> Log: >>> Remove the defunct remains of the TCPS_TIME_WAIT cases from >>> tcp_do_segment >>> and change it to a void function. >>> >>> We use a compressed structure for TCPS_TIME_WAIT to save memory. Any >>> late >>> late segments arriving for such a connection is handled directly in the >>> TW >>> code. >> >> Since tcp_subr.c is such a catch-all, and quite long, I've was thinking >> last night that we might want to move the tcp_tw* functions (and related >> bits) into tcp_timewait.c. It could be that if we do that, since it will >> be 99% post-Berkeley code, that we want to apply the copyright/license from >> tcp_syncache.c, as jlemon did the timewait code under the same contract as >> the syncache/syncookie work, but we should check with him. > > Good idea. Will you check with him or shall I? If you could, that would be good -- I'm a bit overwhelmed with stuff right now. Feel free to CC me, as I supervised the contract at NAI/McAfe. Robert N M Watson Computer Laboratory University of Cambridge