From owner-cvs-all Wed Dec 1 13:24:32 1999 Delivered-To: cvs-all@freebsd.org Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by hub.freebsd.org (Postfix) with ESMTP id 2C90514C26; Wed, 1 Dec 1999 13:24:07 -0800 (PST) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.9.1/8.9.1) with ESMTP id QAA11710; Wed, 1 Dec 1999 16:22:13 -0500 (EST) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.9.3/8.9.1) id QAA63877; Wed, 1 Dec 1999 16:21:43 -0500 (EST) (envelope-from gallatin@cs.duke.edu) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Date: Wed, 1 Dec 1999 16:21:43 -0500 (EST) To: Kirk McKusick Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mount.h src/sys/kern vfs_bio.c src/sys/miscfs/specfs spec_vnops.c In-Reply-To: <199912010209.SAA68538@freefall.freebsd.org> References: <199912010209.SAA68538@freefall.freebsd.org> X-Mailer: VM 6.43 under 20.4 "Emerald" XEmacs Lucid Message-ID: <14405.36736.721812.91039@grasshopper.cs.duke.edu> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Kirk McKusick writes: > out. The old mount binary is completely compatible, the only > reason to install a new mount is to get the read counts printed. Unless you are running on an alpha, where sizeof(long) == 8 ;-) There you are stuck: <...> pid 11 (fsck), uid 0: exited on signal 11 (core dumped) Segmentation fault - core dumped Unknown error in reboot <...> I'd like to see mount stay backwards/forwards compatible if possible. There are 2 ways to fix this -- adjust MNAMELEN down on alpha, or change the types of the added fields from longs to u_int32_t's. I have verified the following (adjusting MNAMELEN down to 72) works, should I go ahead & commit it? Index: mount.h =================================================================== RCS file: /home/ncvs/src/sys/sys/mount.h,v retrieving revision 1.85 diff -u -c -r1.85 mount.h cvs diff: conflicting specifications of output style *** mount.h 1999/12/01 02:09:19 1.85 --- mount.h 1999/12/01 21:07:37 *************** *** 67,73 **** --- 67,78 ---- */ #define MFSNAMELEN 16 /* length of fs type name, including null */ + #ifdef __i386__ #define MNAMELEN 80 /* length of buffer for returned name */ + #endif + #ifdef __alpha__ + #define MNAMELEN 72 /* length of buffer for returned name */ + #endif struct statfs { long f_spare2; /* placeholder */ Thanks! Drew ------------------------------------------------------------------------------ Andrew Gallatin, Sr Systems Programmer http://www.cs.duke.edu/~gallatin Duke University Email: gallatin@cs.duke.edu Department of Computer Science Phone: (919) 660-6590 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message